Fixed the font property

[Nj221102]

Description

previously font- shorthand property wasn't working properly because the specific property for the font size was overwriting the font property and it has a default value so it was never nil, hence making the size section in the font useless.

so to overcome this problem and fix it, I made some changes so now font wouldn't write to a font property, but instead to the specific ones ,which will do three things:-

1. if there is no font property then specific properties will work as it is.
2. but if there are some properties mentioned in the shorthand property then those properties will overwrite their respective specific property, which means the things written in the font will applied,not what's written in specific ones.
3. if there is some property which is not present in font property, like family, italic, or weight is present in font-shorthand but no size input is there, then in this case if you write the size in specific :size property ,then it will also work.

All these features are similar to how shoes used to work

Shoes.app do
    
    para "The family is not in font so it will change but size won't" , font:"italic bold 30px" , family:"cursive", size: 20

    para "because  only things things who aren't present in font " , font:"bold", size: "16px"

    para "will be used as their specific property", font: "cursive italic 20px ", font_weight:"bold"

end

Image(if needed, helps for a faster review)

Checklist

• Run tests locally

[noahgibbs]

I'm also seeing some odd things with quoted font family versus unquoted (e.g. font: "Pacifico" vs font: "'Pacifico'"). Probably time to add some tests...

[Nj221102]

@noahgibbs I have added the test for the parsing logic

Is there a need for further changes, please suggest .

[noahgibbs]

Minor thing, but it probably makes more sense to put the require up at the top unless it's inside a method. In this case, up top makes more sense.

[noahgibbs]

Normally you wouldn't use an underscore here. It would be FontHelper rather than Font_helper.

[Nj221102]

Done : )

[noahgibbs]

If you want an includable module, you'd normally define these as instance methods (e.g. "def parse_font") rather than self methods. It would be fine to have it free-standing like this and call FontHelper.parse_font, but then you don't need the includes for it. Or you could use the includes, call the methods as "parse_font" rather than "FontHelper.parse_font" and not define them with "self" in front.

[noahgibbs]

Thank you! Merged.

[Schwad]

This is an excellent contribution. Thank you!

One thought, no need to take action but thinking out loud.

For readability in future it could be nice to use descriptive variable names; for what concept they are representing.

(Thinking about the "fs, foss, etc.")

Thanks again!

[Nj221102]

Thanks for the advice , will keep that in mind while writing code in future : )