Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for UI localization and some customization #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

felix91gr
Copy link

Hi @scarfacedeb,

Here's what you taught me, documented in the README.

The version I made probably needs a couple more iterations, please tell me what you would change about it.

I would like to also add a section about how to do #33 properly. That way the README explains every little bit of UI customization that the user might need (I think).

@scarfacedeb
Copy link
Owner

@felix91gr Thank you, it looks good to me.

I think it's worth mentioning Model#model_name#i18n_key method, as in Cms::Page.model_name.i18n_key. It's the one that I18n library uses in yaml file.

@felix91gr
Copy link
Author

Model#model_name#i18n_key

What is that? :o

@scarfacedeb
Copy link
Owner

Don't worry about it, that's my way of writing a nested call to instance methods. :)

Actually, Model.model_name is not even an instance method!

Anyway, it supposed to represent Cms::Page.model_name.i18n_key method calls.

@felix91gr
Copy link
Author

Ohh, I see!

Btw, the #33 usage documentation is now in. Lemme know what you think!

As soon as you give it a 👍 and merge #36, I'll update the URLs of the images so that they point to the copies in this repo :3

@felix91gr felix91gr changed the title [WIP] Documentation for UI localization Documentation for UI localization and some customization Oct 14, 2019
@scarfacedeb
Copy link
Owner

@felix91gr Hello again, could you rewrite the README to mention customization of tab labels via admin.globalize_field.tab_label, instead of monkey patching? It should make it more straightforward to customize the labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants