DPDV-6531: Retry when server does not return JSON #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Link: https://sentinelone.atlassian.net/browse/DPDV-6531
🥅 Goal
Retry to send requests even when the server is not sending expected (JSON) response.
🛠️ Solution
Original version was not retrying when it was not possible to connect to the server or when it returned response in different format then expected. Since this situation can happen during some system outages -
upstream connect error or disconnect/reset before headers. reset reason: connection termination
:We should retry. Hopefully the server recovers meanwhile.
🏫 Testing
I have added test for this scenario.
📓 Note
I have also updated dependabot configuration, so it updates also examples, so we do not have this version changes in the future.