Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

salt,tests: Kubernetes Cronjob management Salt module #4240

Merged
merged 2 commits into from
Feb 29, 2024
Merged

salt,tests: Kubernetes Cronjob management Salt module #4240

merged 2 commits into from
Feb 29, 2024

Conversation

aprucolimartins
Copy link
Contributor

@aprucolimartins aprucolimartins commented Feb 16, 2024 •
edited
Loading

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Feb 16, 2024

Hello aprucolimartins,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 16, 2024

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@aprucolimartins aprucolimartins force-pushed the improvement/ARTESCA-11283_metalk8s_cronjob_salt_module branch from 981ca07 to c451640 Compare February 20, 2024 16:39
@ezekiel-alexrod ezekiel-alexrod force-pushed the improvement/ARTESCA-11283_metalk8s_cronjob_salt_module branch 4 times, most recently from 86435b3 to c763f83 Compare February 27, 2024 13:11
@ezekiel-alexrod ezekiel-alexrod marked this pull request as ready for review February 27, 2024 13:13
@ezekiel-alexrod ezekiel-alexrod requested a review from a team as a code owner February 27, 2024 13:13
@ezekiel-alexrod ezekiel-alexrod changed the title ARTESCA-11283 metalk8s cronjob salt module salt,tests: Kubernetes Cronjob management Salt module Feb 27, 2024
@ezekiel-alexrod
Copy link
Contributor

Need to comment the function for clarity

TeddyAndrieux
TeddyAndrieux requested changes Feb 27, 2024
View reviewed changes
salt/_modules/metalk8s_kubernetes_cronjob.py Outdated Show resolved Hide resolved
salt/_modules/metalk8s_kubernetes_cronjob.py Outdated Show resolved Hide resolved
salt/_modules/metalk8s_kubernetes_cronjob.py Outdated Show resolved Hide resolved
salt/_modules/metalk8s_kubernetes_cronjob.py Outdated Show resolved Hide resolved
salt/_modules/metalk8s_kubernetes_cronjob.py Outdated Show resolved Hide resolved
salt/_modules/metalk8s_kubernetes_cronjob.py Outdated Show resolved Hide resolved
salt/_modules/metalk8s_kubernetes_cronjob.py Outdated Show resolved Hide resolved
salt/_modules/metalk8s_kubernetes_cronjob.py Outdated Show resolved Hide resolved
salt/_modules/metalk8s_kubernetes_cronjob.py Outdated Show resolved Hide resolved
@ezekiel-alexrod ezekiel-alexrod force-pushed the improvement/ARTESCA-11283_metalk8s_cronjob_salt_module branch from c763f83 to be55c32 Compare February 27, 2024 16:52
@ezekiel-alexrod
Copy link
Contributor

ezekiel-alexrod commented Feb 27, 2024 •
edited
Loading

Still needs comments and print were omitted
One last push to do

@ezekiel-alexrod ezekiel-alexrod force-pushed the improvement/ARTESCA-11283_metalk8s_cronjob_salt_module branch 2 times, most recently from 63d2877 to 9277ef3 Compare February 28, 2024 10:24
TeddyAndrieux
TeddyAndrieux reviewed Feb 28, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
TeddyAndrieux
TeddyAndrieux reviewed Feb 28, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ezekiel-alexrod ezekiel-alexrod force-pushed the improvement/ARTESCA-11283_metalk8s_cronjob_salt_module branch from 9277ef3 to cea00c2 Compare February 28, 2024 10:28
@ezekiel-alexrod ezekiel-alexrod force-pushed the improvement/ARTESCA-11283_metalk8s_cronjob_salt_module branch from cea00c2 to 11c1845 Compare February 28, 2024 11:16
@ezekiel-alexrod ezekiel-alexrod force-pushed the improvement/ARTESCA-11283_metalk8s_cronjob_salt_module branch from 11c1845 to 4257acd Compare February 28, 2024 12:53
@ezekiel-alexrod ezekiel-alexrod force-pushed the improvement/ARTESCA-11283_metalk8s_cronjob_salt_module branch from 4257acd to 33c4639 Compare February 28, 2024 12:58
TeddyAndrieux
TeddyAndrieux previously approved these changes Feb 28, 2024
View reviewed changes
@aprucolimartins
Copy link
Contributor Author

/approve

@scality scality deleted a comment from bert-e Feb 28, 2024
@bert-e
Copy link
Contributor

bert-e commented Feb 28, 2024

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/125.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 28, 2024

Build failed

The build for commit did not succeed in branch improvement/ARTESCA-11283_metalk8s_cronjob_salt_module.

The following options are set: approve

@ezekiel-alexrod ezekiel-alexrod force-pushed the improvement/ARTESCA-11283_metalk8s_cronjob_salt_module branch from 33c4639 to e15f700 Compare February 28, 2024 13:15
@bert-e
Copy link
Contributor

bert-e commented Feb 28, 2024

History mismatch

Merge commit #2c9c49af789547337cb59f481f987a4645d3c0cd on the integration branch
w/127.0/improvement/ARTESCA-11283_metalk8s_cronjob_salt_module is merging a branch which is neither the current
branch improvement/ARTESCA-11283_metalk8s_cronjob_salt_module nor the development branch
development/127.0.

It is likely due to a rebase of the branch improvement/ARTESCA-11283_metalk8s_cronjob_salt_module and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

@aprucolimartins
Copy link
Contributor Author

/reset

@bert-e
Copy link
Contributor

bert-e commented Feb 28, 2024

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 28, 2024

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/125.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 28, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@scality scality deleted a comment from bert-e Feb 28, 2024
@scality scality deleted a comment from bert-e Feb 28, 2024
@bert-e
Copy link
Contributor

bert-e commented Feb 28, 2024

Build failed

The build for commit did not succeed in branch w/127.0/improvement/ARTESCA-11283_metalk8s_cronjob_salt_module.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 28, 2024

Build failed

The build for commit did not succeed in branch improvement/ARTESCA-11283_metalk8s_cronjob_salt_module.

The following options are set: approve

@ezekiel-alexrod ezekiel-alexrod force-pushed the improvement/ARTESCA-11283_metalk8s_cronjob_salt_module branch from e15f700 to 56eb9c1 Compare February 29, 2024 08:47
@bert-e
Copy link
Contributor

bert-e commented Feb 29, 2024

History mismatch

Merge commit #7bc57ff638c823152f785bc022d9497663a42043 on the integration branch
w/127.0/improvement/ARTESCA-11283_metalk8s_cronjob_salt_module is merging a branch which is neither the current
branch improvement/ARTESCA-11283_metalk8s_cronjob_salt_module nor the development branch
development/127.0.

It is likely due to a rebase of the branch improvement/ARTESCA-11283_metalk8s_cronjob_salt_module and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

@ezekiel-alexrod
Copy link
Contributor

/reset

@bert-e
Copy link
Contributor

bert-e commented Feb 29, 2024

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 29, 2024

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/125.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 29, 2024

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/126.0

  • ✔️ development/127.0

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/125.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 29, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/126.0

  • ✔️ development/127.0

The following branches have NOT changed:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/125.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue ARTESCA-11283.

Goodbye aprucolimartins.

@aprucolimartins aprucolimartins merged commit c85dc2d into development/126.0 Feb 29, 2024
26 checks passed
@aprucolimartins aprucolimartins deleted the improvement/ARTESCA-11283_metalk8s_cronjob_salt_module branch February 29, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezekiel-alexrod ezekiel-alexrod ezekiel-alexrod left review comments

@TeddyAndrieux TeddyAndrieux TeddyAndrieux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aprucolimartins @bert-e @ezekiel-alexrod @TeddyAndrieux