Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salt,tools: Remove OOMKilled alerts #4067

Merged
merged 1 commit into from
May 31, 2023

Conversation

TeddyAndrieux
Copy link
Collaborator

It seems in some specific context that those alerts make Prometheus consume way too much memory, so let's remove them for the moment (they might be added back in the future after more investigation on this memory consumption)

@TeddyAndrieux TeddyAndrieux requested a review from a team as a code owner May 31, 2023 15:07
@bert-e
Copy link
Contributor

bert-e commented May 31, 2023

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e

This comment was marked as resolved.

It seems those alerts make Prometheus consume way too much memory, so
let's remove them for the moment (they might be added back in the future
after some investigation on this memory consumption)
@TeddyAndrieux TeddyAndrieux force-pushed the bugfix/remove-oom-kill-alerts branch from 9098c35 to a559ee8 Compare May 31, 2023 15:08
Comment on lines -6 to -20
### Enhancements

- Add Out Of Memory alerts for containers
(PR[#4042](https://github.com/scality/metalk8s/pull/4042))
### Bug fixes

- Ensure metalk8s-sosreport package get upgraded on each patch version.
Changes metalk8s-sosreport package version to add the `patch` digit
(PR[#4056](https://github.com/scality/metalk8s/pull/4056))

### Enhancements

- Add Out Of Memory alerts for containers
(PR[#4042](https://github.com/scality/metalk8s/pull/4042))

Copy link
Collaborator Author

@TeddyAndrieux TeddyAndrieux May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers that this was not part of 124.1.6, just the PR get merged before the 124.1.6 tag was merged (that's why I only remove them and do not add anything about this removal in changelog here)

@bert-e
Copy link
Contributor

bert-e commented May 31, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@TeddyAndrieux
Copy link
Collaborator Author

/approve

@bert-e
Copy link
Contributor

bert-e commented May 31, 2023

Build failed

The build for commit did not succeed in branch bugfix/remove-oom-kill-alerts.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 31, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/124.1

  • ✔️ development/125.0

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 31, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/124.1

  • ✔️ development/125.0

The following branches have NOT changed:

  • development/123.0
  • development/124.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye teddyandrieux.

@bert-e bert-e merged commit a559ee8 into development/124.1 May 31, 2023
@bert-e bert-e deleted the bugfix/remove-oom-kill-alerts branch May 31, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants