-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
salt,tools: Remove OOMKilled alerts #4067
Conversation
Hello teddyandrieux,My role is to assist you with the merge of this Status report is not available. |
This comment was marked as resolved.
This comment was marked as resolved.
It seems those alerts make Prometheus consume way too much memory, so let's remove them for the moment (they might be added back in the future after some investigation on this memory consumption)
9098c35
to
a559ee8
Compare
### Enhancements | ||
|
||
- Add Out Of Memory alerts for containers | ||
(PR[#4042](https://github.com/scality/metalk8s/pull/4042)) | ||
### Bug fixes | ||
|
||
- Ensure metalk8s-sosreport package get upgraded on each patch version. | ||
Changes metalk8s-sosreport package version to add the `patch` digit | ||
(PR[#4056](https://github.com/scality/metalk8s/pull/4056)) | ||
|
||
### Enhancements | ||
|
||
- Add Out Of Memory alerts for containers | ||
(PR[#4042](https://github.com/scality/metalk8s/pull/4042)) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers that this was not part of 124.1.6, just the PR get merged before the 124.1.6 tag was merged (that's why I only remove them and do not add anything about this removal in changelog here)
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
/approve |
Build failedThe build for commit did not succeed in branch bugfix/remove-oom-kill-alerts. The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue None. Goodbye teddyandrieux. |
It seems in some specific context that those alerts make Prometheus consume way too much memory, so let's remove them for the moment (they might be added back in the future after more investigation on this memory consumption)