Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTESCA-7317: enable webhook on deployment #4032

Merged

Conversation

lamphamsy
Copy link
Contributor

Component: 'salt'

Context:
To enable webhook on deployment.

Summary:
Add volume to use secret to configure webhook in a deployment. This volume is configured when solution.sh is executed with the flag -w or --webhook.

Acceptance criteria:

@lamphamsy lamphamsy requested a review from a team as a code owner March 23, 2023 12:57
@bert-e
Copy link
Contributor

bert-e commented Mar 23, 2023

Hello lamphamsy,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Mar 23, 2023

Branches have diverged

This pull request's source branch feature/ARTESCA-7317_enable_webhook_deployment has diverged from
development/125.0 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

  • Merge origin/development/125.0 into feature/ARTESCA-7317_enable_webhook_deployment
  • Rebase feature/ARTESCA-7317_enable_webhook_deployment onto origin/development/125.0

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

Copy link

@lavigne958 lavigne958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 👍

Copy link
Collaborator

@TeddyAndrieux TeddyAndrieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the quote on boolean (and if you could just add a line about it in CHANGELOG.md in Additions)

scripts/solutions.sh Outdated Show resolved Hide resolved
salt/tests/unit/formulas/config.yaml Outdated Show resolved Hide resolved
@lamphamsy lamphamsy force-pushed the feature/ARTESCA-7317_enable_webhook_deployment branch from 98329fb to 6516bb1 Compare March 24, 2023 15:10
@lamphamsy lamphamsy requested review from TeddyAndrieux, lavigne958 and a team March 24, 2023 15:11
Add volume to use secret to configure webhook in a deployment.
This volume is configured when solution.sh is executed with the
flag `-w` or `--webhook`.
@lamphamsy lamphamsy force-pushed the feature/ARTESCA-7317_enable_webhook_deployment branch from 6516bb1 to f047356 Compare March 24, 2023 18:29
@bert-e
Copy link
Contributor

bert-e commented Mar 24, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@lamphamsy
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Mar 29, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/125.0

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 29, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/125.0

The following branches have NOT changed:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue ARTESCA-7317.

Goodbye lamphamsy.

@bert-e bert-e merged commit 6e17c24 into development/125.0 Mar 29, 2023
@bert-e bert-e deleted the feature/ARTESCA-7317_enable_webhook_deployment branch March 29, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants