-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARTESCA-7317: enable webhook on deployment #4032
ARTESCA-7317: enable webhook on deployment #4032
Conversation
Hello lamphamsy,My role is to assist you with the merge of this Status report is not available. |
Branches have divergedThis pull request's source branch To avoid any integration risks, please re-synchronize them using one of the
Note: If you choose to rebase, you may have to ask me to rebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the quote on boolean (and if you could just add a line about it in CHANGELOG.md
in Additions
)
98329fb
to
6516bb1
Compare
Add volume to use secret to configure webhook in a deployment. This volume is configured when solution.sh is executed with the flag `-w` or `--webhook`.
6516bb1
to
f047356
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARTESCA-7317. Goodbye lamphamsy. |
Component: 'salt'
Context:
To enable webhook on deployment.
Summary:
Add volume to use secret to configure webhook in a deployment. This volume is configured when solution.sh is executed with the flag
-w
or--webhook
.Acceptance criteria: