Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically rotate the script logfiles #4030

Merged
merged 3 commits into from
Mar 20, 2023

Conversation

eg-ayoub
Copy link
Contributor

No description provided.

@eg-ayoub eg-ayoub requested a review from a team as a code owner March 17, 2023 16:33
@bert-e
Copy link
Contributor

bert-e commented Mar 17, 2023

Hello eg-ayoub,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Mar 17, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@eg-ayoub eg-ayoub force-pushed the improvement/rotate-bash-logs branch from a794507 to eaf17d6 Compare March 17, 2023 16:40
Copy link
Collaborator

@TeddyAndrieux TeddyAndrieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 minor comments otherwise LGTM

Just add a changelog entry for it please :)

@eg-ayoub eg-ayoub force-pushed the improvement/rotate-bash-logs branch from eaf17d6 to 9e5b1fe Compare March 20, 2023 09:31
@eg-ayoub eg-ayoub requested a review from TeddyAndrieux March 20, 2023 09:31
Copy link
Collaborator

@TeddyAndrieux TeddyAndrieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Still miss the changelog entry btw)

@eg-ayoub eg-ayoub force-pushed the improvement/rotate-bash-logs branch from 9e5b1fe to c959ef3 Compare March 20, 2023 10:16
@TeddyAndrieux TeddyAndrieux changed the title logfile names contain dates Automatically rotate the script logfiles Mar 20, 2023
TeddyAndrieux
TeddyAndrieux previously approved these changes Mar 20, 2023
Copy link
Collaborator

@TeddyAndrieux TeddyAndrieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@eg-ayoub
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Mar 20, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/125.0

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 20, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/125.0

The following branches have NOT changed:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye eg-ayoub.

@bert-e bert-e merged commit b629d64 into development/125.0 Mar 20, 2023
@bert-e bert-e deleted the improvement/rotate-bash-logs branch March 20, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants