Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

salt: Add a workaround CronJob to delete old Loki chunks #3923

Merged
merged 1 commit into from
Nov 30, 2022
Merged

salt: Add a workaround CronJob to delete old Loki chunks #3923

merged 1 commit into from
Nov 30, 2022

Conversation

TeddyAndrieux
Copy link
Collaborator

@TeddyAndrieux TeddyAndrieux commented Nov 28, 2022 •
edited
Loading

Waiting for a proper fix, add a simple CronJob to delete old Loki chunks

@TeddyAndrieux TeddyAndrieux requested a review from a team as a code owner November 28, 2022 17:55
@TeddyAndrieux TeddyAndrieux changed the base branch from q/124.1 to development/124.1 November 28, 2022 21:12
@bert-e
Copy link
Contributor

bert-e commented Nov 28, 2022

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 28, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@TeddyAndrieux TeddyAndrieux force-pushed the bugfix/add-workaround-for-loki-retention branch from 9696b61 to 6b24fe8 Compare November 29, 2022 12:29
@TeddyAndrieux TeddyAndrieux changed the base branch from development/124.1 to q/124.1 November 29, 2022 12:37
@TeddyAndrieux TeddyAndrieux force-pushed the bugfix/add-workaround-for-loki-retention branch from 6b24fe8 to d6eb4f4 Compare November 29, 2022 12:46
@TeddyAndrieux TeddyAndrieux changed the base branch from q/124.1 to development/124.1 November 29, 2022 16:04
JBWatenbergScality
JBWatenbergScality previously approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@JBWatenbergScality JBWatenbergScality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with few comments, feel free to address them if you can/consider them relevant

salt/metalk8s/addons/logging/loki/deployed/init.sls Outdated Show resolved Hide resolved
salt/metalk8s/addons/logging/loki/deployed/pre-upgrade.sls Show resolved Hide resolved
@bert-e
Copy link
Contributor

bert-e commented Nov 29, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@TeddyAndrieux
salt: Add a workaround CronJob to delete old Loki chunks
934a3bc 
Waiting for a proper fix add a simple CronJob to delete old Loki chunks
@TeddyAndrieux TeddyAndrieux force-pushed the bugfix/add-workaround-for-loki-retention branch from d6eb4f4 to 934a3bc Compare November 30, 2022 08:54
@TeddyAndrieux
Copy link
Collaborator Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Nov 30, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/124.1

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Nov 30, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/124.1

The following branches have NOT changed:

  • development/123.0
  • development/124.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye teddyandrieux.

@bert-e bert-e merged commit 934a3bc into development/124.1 Nov 30, 2022
@bert-e bert-e deleted the bugfix/add-workaround-for-loki-retention branch November 30, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdemonet gdemonet gdemonet approved these changes

@JBWatenbergScality JBWatenbergScality JBWatenbergScality left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TeddyAndrieux @bert-e @gdemonet @JBWatenbergScality