Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charts,salt,tests: Do no longer use loadBalancerIP field for svc #3834

Merged
merged 1 commit into from
Jul 28, 2022
Merged

charts,salt,tests: Do no longer use loadBalancerIP field for svc #3834

merged 1 commit into from
Jul 28, 2022

Conversation

TeddyAndrieux
Copy link
Collaborator

Since Kubernetes 1.24 setting the loadBalancerIP on a Service is
deprecated

@TeddyAndrieux TeddyAndrieux requested a review from a team as a code owner July 28, 2022 12:42
@bert-e
Copy link
Contributor

bert-e commented Jul 28, 2022

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jul 28, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

gdemonet
gdemonet previously approved these changes Jul 28, 2022
View reviewed changes
@TeddyAndrieux TeddyAndrieux force-pushed the improvement/no-longer-use-deprecated-field-lb-svc branch from 177bdfc to e11e13a Compare July 28, 2022 13:56
@TeddyAndrieux
Copy link
Collaborator Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jul 28, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

gdemonet
gdemonet previously approved these changes Jul 28, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@TeddyAndrieux
charts,salt,tests: Do no longer use loadBalancerIP field for svc
4b3b79d 
Since Kubernetes 1.24 setting the `loadBalancerIP` on a Service is
deprecated

Re-render salt state using:
```
./charts/render.py ingress-nginx-control-plane --namespace metalk8s-ingress \
  charts/ingress-nginx-control-plane-deployment.yaml charts/ingress-nginx/ \
  > salt/metalk8s/addons/nginx-ingress-control-plane/deployed/chart-deployment.sls
```
@TeddyAndrieux TeddyAndrieux force-pushed the improvement/no-longer-use-deprecated-field-lb-svc branch from e11e13a to 4b3b79d Compare July 28, 2022 13:58
@bert-e
Copy link
Contributor

bert-e commented Jul 28, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/124.0

The following branches will NOT be impacted:

  • development/123.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jul 28, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/124.0

The following branches have NOT changed:

  • development/123.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye teddyandrieux.

@bert-e bert-e merged commit 4b3b79d into development/124.0 Jul 28, 2022
@bert-e bert-e deleted the improvement/no-longer-use-deprecated-field-lb-svc branch July 28, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdemonet gdemonet gdemonet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TeddyAndrieux @bert-e @gdemonet