-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement/module federation initial load perf improvements #3745
Improvement/module federation initial load perf improvements #3745
Conversation
Hello jbwatenbergscality,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list:
|
e45cb0f
to
852bce1
Compare
This change allow to lighten remoteEntry bundles as dependencies set as non eager can be loaded asynchronously (and possibly in parallel under some conditions). It also avoid downloading common dependencies twice when loading a federated application.
8fc1e23
to
9b1ae77
Compare
/approve |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list:
The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue None. Goodbye jbwatenbergscality. |
Component:
ui/shell-ui
Context:
Metalk8s UI was beforehand bundling a certain amount of dependencies within it's remoteEntry bundle (due to the eager flag being set on).
This was consequently slowing down UI loading time.
Summary:
This PR improve UI performance by a very high factor (on application where Metalk8s UI is deployed aside of 2 other UI project I've noted a drop of initial loading time from 4.3 seconds to 1.3 seconds, with react being in dev mode so In prod I would expect an even better improvement).