Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/module federation initial load perf improvements #3745

Conversation

JBWatenbergScality
Copy link
Contributor

@JBWatenbergScality JBWatenbergScality commented Apr 7, 2022

Component:

ui/shell-ui

Context:

Metalk8s UI was beforehand bundling a certain amount of dependencies within it's remoteEntry bundle (due to the eager flag being set on).
This was consequently slowing down UI loading time.

Summary:

This PR improve UI performance by a very high factor (on application where Metalk8s UI is deployed aside of 2 other UI project I've noted a drop of initial loading time from 4.3 seconds to 1.3 seconds, with react being in dev mode so In prod I would expect an even better improvement).

@bert-e
Copy link
Contributor

bert-e commented Apr 7, 2022

Hello jbwatenbergscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Apr 7, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JBWatenbergScality JBWatenbergScality force-pushed the improvement/module-federation-initial-load-perf-improvements branch 5 times, most recently from e45cb0f to 852bce1 Compare April 8, 2022 15:52
This change allow to lighten remoteEntry bundles as dependencies set as non eager can be loaded asynchronously (and possibly in parallel under some conditions).
It also avoid downloading common dependencies twice when loading a federated application.
@JBWatenbergScality JBWatenbergScality force-pushed the improvement/module-federation-initial-load-perf-improvements branch from 8fc1e23 to 9b1ae77 Compare April 11, 2022 13:01
@JBWatenbergScality JBWatenbergScality marked this pull request as ready for review April 11, 2022 13:06
@JBWatenbergScality JBWatenbergScality requested a review from a team as a code owner April 11, 2022 13:06
MonPote
MonPote previously approved these changes Apr 11, 2022
@JBWatenbergScality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Apr 13, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Apr 13, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/123.0

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Apr 21, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/123.0

The following branches have NOT changed:

  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye jbwatenbergscality.

@bert-e bert-e merged commit 6852dac into development/123.0 Apr 21, 2022
@bert-e bert-e deleted the improvement/module-federation-initial-load-perf-improvements branch April 21, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants