-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts,salt: Do not reconfigure repository in local mode #3741
scripts,salt: Do not reconfigure repository in local mode #3741
Conversation
Since salt state to configure the repository rely on some variable from pillar available in salt-master to manage the solution images, if we run the repository state in local mode the solution image will no longer be available in the registry To avoid that kind of issue during the upgrade we only run the salt master state in local mode
Hello teddyandrieux,My role is to assist you with the merge of this Status report is not available. |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
|
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you tested the upgrade with those changes, code LGTM 👌
Indeed I did |
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue None. Goodbye teddyandrieux. |
Since the salt state to configure the repository relies on some variable from
pillar available in salt-master to manage the solution images, if we run
the repository state in local mode the solution image will no longer be
available in the registry
To avoid that kind of issue during the upgrade we only run the salt
master state in local mode