-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
salt,tests: Allow to resolve registry endpoint from containers #3690
salt,tests: Allow to resolve registry endpoint from containers #3690
Conversation
Hello teddyandrieux,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list:
|
In some cases, we may want to get some "stuff" from the internal registry from inside a container (for example an operator that try to retrieve some information from the registry). Since we use a "fake" endpoint in containerd config file to reach the registries, this commit make this "fake" endpoint also available when resolving name with CoreDNS as we `rewrite` the "fake" endpoint name to resolve to a non-headless service that points to the registry. NOTE: We need to use a non-headless service as we want to forward the port so that we have the same behavior as the fake endpoint configured in containerd
3caec07
to
e51a7b9
Compare
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue None. Goodbye teddyandrieux. |
In some cases, we may want to get some "stuff" from the internal registry
from inside a container (for example an operator that try to retrieve
some information from the registry).
Since we use a "fake" endpoint in containerd config file to reach the
registries, this commit make this "fake" endpoint also available when
resolving name with CoreDNS as we
rewrite
the "fake" endpoint name toresolve to a non-headless service that points to the registry.
NOTE: We need to use a non-headless service as we want to forward the
port so that we have the same behavior as the fake endpoint configured
in containerd