Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salt,tests: Allow to resolve registry endpoint from containers #3690

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

TeddyAndrieux
Copy link
Collaborator

In some cases, we may want to get some "stuff" from the internal registry
from inside a container (for example an operator that try to retrieve
some information from the registry).

Since we use a "fake" endpoint in containerd config file to reach the
registries, this commit make this "fake" endpoint also available when
resolving name with CoreDNS as we rewrite the "fake" endpoint name to
resolve to a non-headless service that points to the registry.

NOTE: We need to use a non-headless service as we want to forward the
port so that we have the same behavior as the fake endpoint configured
in containerd

@TeddyAndrieux TeddyAndrieux requested a review from a team February 4, 2022 14:56
@bert-e
Copy link
Contributor

bert-e commented Feb 4, 2022

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 4, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

In some cases, we may want to get some "stuff" from the internal registry
from inside a container (for example an operator that try to retrieve
some information from the registry).

Since we use a "fake" endpoint in containerd config file to reach the
registries, this commit make this "fake" endpoint also available when
resolving name with CoreDNS as we `rewrite` the "fake" endpoint name to
resolve to a non-headless service that points to the registry.

NOTE: We need to use a non-headless service as we want to forward the
port so that we have the same behavior as the fake endpoint configured
in containerd
@TeddyAndrieux TeddyAndrieux force-pushed the improvement/add-rewrite-for-registry branch from 3caec07 to e51a7b9 Compare February 4, 2022 14:57
@TeddyAndrieux
Copy link
Collaborator Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Feb 4, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/123.0

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 4, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/123.0

The following branches have NOT changed:

  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye teddyandrieux.

@bert-e bert-e merged commit e51a7b9 into development/123.0 Feb 4, 2022
@bert-e bert-e deleted the improvement/add-rewrite-for-registry branch February 4, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants