Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rocky linux support #3686

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Rocky linux support #3686

merged 2 commits into from
Feb 7, 2022

Conversation

alexandre-allard
Copy link
Contributor

@alexandre-allard alexandre-allard commented Feb 3, 2022 •
edited
Loading

No description provided.

@alexandre-allard alexandre-allard requested a review from a team as a code owner February 3, 2022 10:44
@bert-e
Copy link
Contributor

bert-e commented Feb 3, 2022

Hello alexandre-allard-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 3, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@alexandre-allard alexandre-allard changed the title Improvement/rocky linux support Rocky linux support Feb 3, 2022
TeddyAndrieux
TeddyAndrieux reviewed Feb 3, 2022
View reviewed changes
scripts/common.sh.in Outdated Show resolved Hide resolved
TeddyAndrieux
TeddyAndrieux previously approved these changes Feb 3, 2022
View reviewed changes
eve/main.yml Show resolved Hide resolved
@alexandre-allard
salt,build: Add support for Rocky Linux
ea84b40 
In the current Salt version we ship, Rocky Linux
is not supported by Salt, but we workaround it
by setting it as RedHat OS family.
@alexandre-allard
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Feb 4, 2022

Build failed

The build for commit did not succeed in branch improvement/rocky-linux-support.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 7, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/123.0

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 7, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/123.0

The following branches have NOT changed:

  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye alexandre-allard-scality.

@bert-e bert-e merged commit 7662a58 into development/123.0 Feb 7, 2022
@bert-e bert-e deleted the improvement/rocky-linux-support branch February 7, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeddyAndrieux TeddyAndrieux TeddyAndrieux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandre-allard @bert-e @TeddyAndrieux