improvement: use tableV2 in the alert page #3669

gaudiauj · 2022-01-19T12:31:16Z

Component:

AlertPage

Context:

fix bad formating of alerts by using new table

bert-e · 2022-01-19T12:31:18Z

Hello gaudiauj,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2022-01-19T12:31:22Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/alertpage into
development/2.11
w/123.0/bugfix/alertpage will be merged into development/123.0

The following branches will NOT be impacted:

development/2.0
development/2.1
development/2.10
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2022-01-19T12:31:24Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2022-01-19T14:55:17Z

History mismatch

Merge commit #a41bb40034d4681aa9aa7f8b0a9e32abda037077 on the integration branch
w/123.0/bugfix/alertpage is merging a branch which is neither the current
branch bugfix/alertpage nor the development branch
development/123.0.

It is likely due to a rebase of the branch bugfix/alertpage and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

gaudiauj · 2022-01-21T13:05:19Z

/reset

bert-e · 2022-01-21T13:05:26Z

Reset complete

I have successfully deleted this pull request's integration branches.

bert-e · 2022-01-21T13:05:31Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/alertpage into
development/2.11
w/123.0/bugfix/alertpage will be merged into development/123.0

The following branches will NOT be impacted:

development/2.0
development/2.1
development/2.10
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2022-01-21T13:05:33Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

ui/src/containers/AlertPage.js

ChengYanJin · 2022-01-21T15:17:03Z

ui/src/containers/AlertPage.js

  const leafAlerts = useMemo(
    () => alerts?.alerts.filter((alert) => !alert.labels.children) || [],
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-    [JSON.stringify(alerts?.alerts)],
+    [alerts?.alerts],


I think we should keep the previous code.

React uses “referential equality” for object and array within the dependencies array.
so even we have the same content of alerts, it will still re-run the effect. That's why we stringify.

A pretty good article to read about.
https://www.benmvp.com/blog/object-array-dependencies-react-useEffect-hook/

bert-e · 2022-01-21T15:25:08Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@ChengYanJin

bert-e · 2022-01-24T13:49:51Z

History mismatch

Merge commit #1f238dd02845ae341eac4efaeded1e958ab18456 on the integration branch
w/123.0/bugfix/alertpage is merging a branch which is neither the current
branch bugfix/alertpage nor the development branch
development/123.0.

It is likely due to a rebase of the branch bugfix/alertpage and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

gaudiauj · 2022-01-25T11:01:45Z

/reset

bert-e · 2022-01-25T11:01:51Z

Reset complete

I have successfully deleted this pull request's integration branches.

bert-e · 2022-01-25T11:01:57Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/alertpage into
development/2.11
w/123.0/bugfix/alertpage will be merged into development/123.0

The following branches will NOT be impacted:

development/2.0
development/2.1
development/2.10
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2022-01-25T11:01:59Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@ChengYanJin

bert-e · 2022-01-25T12:55:26Z

History mismatch

Merge commit #da45c767229ae18f42868fde130c220d9b23beb5 on the integration branch
w/123.0/bugfix/alertpage is merging a branch which is neither the current
branch bugfix/alertpage nor the development branch
development/123.0.

It is likely due to a rebase of the branch bugfix/alertpage and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

gaudiauj · 2022-01-25T16:52:04Z

/reset

bert-e · 2022-01-25T16:52:11Z

Reset complete

I have successfully deleted this pull request's integration branches.

bert-e · 2022-01-25T16:52:17Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/alertpage into
development/2.11
w/123.0/bugfix/alertpage will be merged into development/123.0

The following branches will NOT be impacted:

development/2.0
development/2.1
development/2.10
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2022-01-25T16:52:19Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@ChengYanJin

ChengYanJin · 2022-01-26T10:22:42Z

ui/src/containers/AlertPage.js

  const leafAlerts = useMemo(
    () => alerts?.alerts.filter((alert) => !alert.labels.children) || [],
-    // eslint-disable-next-line react-hooks/exhaustive-deps


You will need to keep this line, otherwise Eslint will complain about about the missing dependency :(

oh my bad will fix this :)

bert-e · 2022-01-26T10:31:04Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

ChengYanJin · 2022-01-27T20:50:06Z

/status

bert-e · 2022-01-27T20:50:09Z

Status

Status report is not available.

bert-e · 2022-01-27T20:50:15Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

gaudiauj · 2022-01-28T12:55:05Z

/approve

bert-e · 2022-01-28T12:55:12Z

Build failed

The build for commit did not succeed in branch w/123.0/bugfix/alertpage.

The following options are set: approve

ChengYanJin · 2022-02-05T20:41:15Z

/status

bert-e · 2022-02-05T20:41:17Z

Status

Status report is not available.

The following options are set: approve

bert-e · 2022-02-05T20:41:24Z

Build failed

The build for commit did not succeed in branch w/123.0/bugfix/alertpage.

The following options are set: approve

bert-e · 2022-02-05T20:48:33Z

History mismatch

Merge commit #fe730ebb380b349462ee182e6580fee21a0d8a55 on the integration branch
w/123.0/bugfix/alertpage is merging a branch which is neither the current
branch bugfix/alertpage nor the development branch
development/123.0.

It is likely due to a rebase of the branch bugfix/alertpage and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

ChengYanJin · 2022-02-05T20:48:51Z

/reset

bert-e · 2022-02-05T20:48:57Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

bert-e · 2022-02-05T20:49:02Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/alertpage into
development/2.11
w/123.0/bugfix/alertpage will be merged into development/123.0

The following branches will NOT be impacted:

development/2.0
development/2.1
development/2.10
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e · 2022-02-05T20:49:04Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

bert-e · 2022-02-07T12:32:45Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.11
✔️ development/123.0

The following branches will NOT be impacted:

development/2.0
development/2.1
development/2.10
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2022-02-07T12:32:53Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.11
✔️ development/123.0

The following branches have NOT changed:

development/2.0
development/2.1
development/2.10
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

Please check the status of the associated issue None.

Goodbye gaudiauj.

gaudiauj requested review from MonPote, ChengYanJin and JBWatenbergScality January 19, 2022 12:31

gaudiauj requested a review from a team as a code owner January 19, 2022 12:31

gaudiauj self-assigned this Jan 19, 2022

gaudiauj force-pushed the bugfix/alertpage branch from a41bb40 to 1f238dd Compare January 19, 2022 14:55

ChengYanJin requested changes Jan 21, 2022

View reviewed changes

gaudiauj force-pushed the bugfix/alertpage branch from 1f238dd to e81431e Compare January 24, 2022 13:49

gaudiauj force-pushed the bugfix/alertpage branch from e81431e to da45c76 Compare January 25, 2022 10:11

gaudiauj force-pushed the bugfix/alertpage branch from da45c76 to fe730eb Compare January 25, 2022 12:55

ChengYanJin previously approved these changes Jan 26, 2022

View reviewed changes

ChengYanJin dismissed their stale review via 27ea007 February 5, 2022 20:48

ChengYanJin force-pushed the bugfix/alertpage branch from fe730eb to 27ea007 Compare February 5, 2022 20:48

improvement: use tableV2 in the alert page

27ea007

ChengYanJin approved these changes Feb 7, 2022

View reviewed changes

bert-e merged commit 27ea007 into development/2.11 Feb 7, 2022

bert-e deleted the bugfix/alertpage branch February 7, 2022 12:32

improvement: use tableV2 in the alert page #3669

improvement: use tableV2 in the alert page #3669

Conversation

gaudiauj commented Jan 19, 2022

bert-e commented Jan 19, 2022

Hello gaudiauj,

bert-e commented Jan 19, 2022

Integration data created

bert-e commented Jan 19, 2022

Waiting for approval

bert-e commented Jan 19, 2022

History mismatch

gaudiauj commented Jan 21, 2022

bert-e commented Jan 21, 2022

Reset complete

bert-e commented Jan 21, 2022

Integration data created

bert-e commented Jan 21, 2022

Waiting for approval

ChengYanJin Jan 21, 2022

Choose a reason for hiding this comment

bert-e commented Jan 21, 2022

Waiting for approval

bert-e commented Jan 24, 2022

History mismatch

gaudiauj commented Jan 25, 2022

bert-e commented Jan 25, 2022

Reset complete

bert-e commented Jan 25, 2022

Integration data created

bert-e commented Jan 25, 2022

Waiting for approval

bert-e commented Jan 25, 2022

History mismatch

gaudiauj commented Jan 25, 2022

bert-e commented Jan 25, 2022

Reset complete

bert-e commented Jan 25, 2022

Integration data created

bert-e commented Jan 25, 2022

Waiting for approval

ChengYanJin Jan 26, 2022

Choose a reason for hiding this comment

gaudiauj Jan 26, 2022

Choose a reason for hiding this comment

bert-e commented Jan 26, 2022

Waiting for approval

ChengYanJin commented Jan 27, 2022

bert-e commented Jan 27, 2022

Status

bert-e commented Jan 27, 2022

Waiting for approval

gaudiauj commented Jan 28, 2022

bert-e commented Jan 28, 2022

Build failed

ChengYanJin commented Feb 5, 2022

bert-e commented Feb 5, 2022

Status

bert-e commented Feb 5, 2022

Build failed

bert-e commented Feb 5, 2022

History mismatch

ChengYanJin commented Feb 5, 2022

bert-e commented Feb 5, 2022

Reset complete

bert-e commented Feb 5, 2022

Integration data created

bert-e commented Feb 5, 2022

Waiting for approval

bert-e commented Feb 7, 2022

In the queue

bert-e commented Feb 7, 2022