salt: Add a udevadm trigger when `persistentPath` does not exists #3630

TeddyAndrieux · 2021-12-07T17:35:02Z

In some cases, a volume may be properly created but the path symlink (
/dev/disks/by-XXX/) does not exist because udevadm did not get
triggered on this device for... whatever reason.

To avoid that kind of issue we now trigger udevadm manually in the salt
execution module when the persistentPath does not exist and the
volume is actually "prepared".

Fixes: #3341

bert-e · 2021-12-07T17:35:04Z

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

salt/_modules/metalk8s_volumes.py

In some cases, a volume may be properly created but the path symlink ( `/dev/disks/by-XXX/`) does not exist because udevadm did not get triggered on this device for... whatever reason. To avoid that kind of issue we now trigger udevadm manually in the salt execution module when the `persistentPath` does not exist and the volume is actually "prepared". Fixes: #3341

bert-e · 2021-12-08T14:27:28Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/update-udev-db-before-dev-detect into
development/2.10
w/2.11/bugfix/update-udev-db-before-dev-detect will be merged into development/2.11
w/123.0/bugfix/update-udev-db-before-dev-detect will be merged into development/123.0

The following branches will NOT be impacted:

development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2021-12-08T14:27:29Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

TeddyAndrieux · 2021-12-08T16:57:17Z

/approve

bert-e · 2021-12-08T17:45:48Z

Build failed

The build for commit did not succeed in branch bugfix/update-udev-db-before-dev-detect.

The following options are set: approve

bert-e · 2021-12-09T08:28:42Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.10
✔️ development/2.11
✔️ development/123.0

The following branches will NOT be impacted:

development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2021-12-09T10:05:14Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.10
✔️ development/2.11
✔️ development/123.0

The following branches have NOT changed:

development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

Please check the status of the associated issue None.

Goodbye teddyandrieux.

TeddyAndrieux requested a review from a team December 7, 2021 17:35