Manage `podAntiAffinity` and number of replicas for CoreDNS #3579

TeddyAndrieux · 2021-10-26T14:24:15Z

Component:

'dns'

Context:

Summary:

Add entry in the bootstrap configuration file to manage the number of replicas to deploy for CoreDNS and the podAntiAffinity.

So that users can set that anti-affinity according to the platform and failure scenario he want to support

Fixes: #3574

bert-e · 2021-10-26T14:24:16Z

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2021-10-26T14:24:21Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

gdemonet · 2021-10-27T09:52:40Z

CHANGELOG.md

@@ -6,6 +6,12 @@
  when observing the cluster state (used in the UI Dashboard page)
  (PR[#3540](https://github.com/scality/metalk8s/pull/3540))

+- [#3574](https://github.com/scality/metalk8s/issues/3574) - Allow to manage
+  number of replicas and, soft and hard `podAntiAffinity` for `CoreDNS`
+  from Bootstrap configuration file, with a default soft anti-affinity on


Why do we want this to live in Bootstrap config? Is CoreDNS required for the control plane to function, or would a CSC ConfigMap (yeah I know, we want to kill CSC) work?

CSC could work as well for this, but ... yeah first we want to kill it, and also to me it's simpler to provide it at "installation" than doing installation then edit a configmap then apply this configmap changes.

And btw to me (I may be wrong), I consider bootstrap config file as configuration for Core stuff (so CoreDNS is part of it) and CSC as "services stuff".
Bootstrap config should likely change a bit and we should have it in Kubernetes (and likely do no longer call it bootstrap).

Anyway, no strong strong opinion, to me today that kind of config could be in CSC or bootstrap, it does not really matter, just on my side I like the fact that I can configure this at installation and not .... you know deploy something I do not want to then change it so that it matches what I want

bert-e · 2021-11-22T15:50:26Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/add-anti-affinity into
development/2.11
w/123.0/improvement/add-anti-affinity will be merged into development/123.0

The following branches will NOT be impacted:

development/2.0
development/2.1
development/2.10
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2021-11-22T15:50:27Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

TeddyAndrieux · 2021-11-22T17:53:55Z

/approve

bert-e · 2021-11-22T17:54:01Z

Build failed

The build for commit did not succeed in branch w/123.0/improvement/add-anti-affinity.

The following options are set: approve

In order to trigger a rollout restart of a deployment or a daemonset, ect, add a salt module to do it. This salt module is equivalent to a `kubectl rollout restart`

Add ability for the user to change podAntiAffinity for CoreDNS deployment and also have a default soft podAntiAffinity on hostname so that if it's possible each CoreDNS replica will sit on a different node by default. Trigger a rollout restart of CoreDNS deployment after deploying a new infra node in order to "apply" soft anti-affinity if possible Fixes: #3574

Refs: #3574

bert-e · 2021-11-22T18:10:28Z

History mismatch

Merge commit #20ba9fe0935b3bffbdd7cdaf2dde15b36e28ce82 on the integration branch
w/123.0/improvement/add-anti-affinity is merging a branch which is neither the current
branch improvement/add-anti-affinity nor the development branch
development/123.0.

It is likely due to a rebase of the branch improvement/add-anti-affinity and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

TeddyAndrieux · 2021-11-22T18:12:42Z

/reset

bert-e · 2021-11-22T18:12:48Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

bert-e · 2021-11-22T18:12:53Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/add-anti-affinity into
development/2.11
w/123.0/improvement/add-anti-affinity will be merged into development/123.0

The following branches will NOT be impacted:

development/2.0
development/2.1
development/2.10
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e · 2021-11-22T18:12:54Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

bert-e · 2021-11-23T10:52:59Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.11
✔️ development/123.0

The following branches will NOT be impacted:

development/2.0
development/2.1
development/2.10
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2021-11-23T10:53:06Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.11
✔️ development/123.0

The following branches have NOT changed:

development/2.0
development/2.1
development/2.10
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

Please check the status of the associated issue None.

Goodbye teddyandrieux.

TeddyAndrieux requested a review from a team October 26, 2021 14:24

TeddyAndrieux force-pushed the improvement/add-anti-affinity branch 3 times, most recently from 9b1a8e9 to a3c8dfa Compare October 27, 2021 07:32

gdemonet reviewed Oct 27, 2021

View reviewed changes

alexandre-allard previously approved these changes Nov 22, 2021

View reviewed changes

TeddyAndrieux added 4 commits November 22, 2021 19:06

docs: Fix code-block type for no_proxy

1ba6b9a

salt: Add execution module to "rollout restart"

7272085

In order to trigger a rollout restart of a deployment or a daemonset, ect, add a salt module to do it. This salt module is equivalent to a `kubectl rollout restart`

salt,docs: Allow to manage number of CoreDNS replica

3615bbb

Refs: #3574

TeddyAndrieux dismissed alexandre-allard’s stale review via 3615bbb November 22, 2021 18:10

TeddyAndrieux force-pushed the improvement/add-anti-affinity branch from a3c8dfa to 3615bbb Compare November 22, 2021 18:10

alexandre-allard approved these changes Nov 23, 2021

View reviewed changes

bert-e merged commit 3615bbb into development/2.11 Nov 23, 2021

bert-e deleted the improvement/add-anti-affinity branch November 23, 2021 10:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Manage `podAntiAffinity` and number of replicas for CoreDNS #3579

Manage `podAntiAffinity` and number of replicas for CoreDNS #3579

TeddyAndrieux commented Oct 26, 2021

bert-e commented Oct 26, 2021

bert-e commented Oct 26, 2021

gdemonet Oct 27, 2021

TeddyAndrieux Oct 27, 2021 •

edited

Loading

bert-e commented Nov 22, 2021

bert-e commented Nov 22, 2021

TeddyAndrieux commented Nov 22, 2021

bert-e commented Nov 22, 2021

bert-e commented Nov 22, 2021

TeddyAndrieux commented Nov 22, 2021

bert-e commented Nov 22, 2021

bert-e commented Nov 22, 2021

bert-e commented Nov 22, 2021

bert-e commented Nov 23, 2021

bert-e commented Nov 23, 2021

Manage podAntiAffinity and number of replicas for CoreDNS #3579

Manage podAntiAffinity and number of replicas for CoreDNS #3579

Conversation

TeddyAndrieux commented Oct 26, 2021

bert-e commented Oct 26, 2021

Hello teddyandrieux,

bert-e commented Oct 26, 2021

Waiting for approval

gdemonet Oct 27, 2021

Choose a reason for hiding this comment

TeddyAndrieux Oct 27, 2021 • edited Loading

Choose a reason for hiding this comment

bert-e commented Nov 22, 2021

Integration data created

bert-e commented Nov 22, 2021

Waiting for approval

TeddyAndrieux commented Nov 22, 2021

bert-e commented Nov 22, 2021

Build failed

bert-e commented Nov 22, 2021

History mismatch

TeddyAndrieux commented Nov 22, 2021

bert-e commented Nov 22, 2021

Reset complete

bert-e commented Nov 22, 2021

Integration data created

bert-e commented Nov 22, 2021

Waiting for approval

bert-e commented Nov 23, 2021

In the queue

bert-e commented Nov 23, 2021

Manage `podAntiAffinity` and number of replicas for CoreDNS #3579

Manage `podAntiAffinity` and number of replicas for CoreDNS #3579

TeddyAndrieux Oct 27, 2021 •

edited

Loading