Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARTESCA-1878: Dashboard Network Plane Health #3522

Closed
wants to merge 1 commit into from
Closed

ARTESCA-1878: Dashboard Network Plane Health #3522

wants to merge 1 commit into from

Conversation

theocerutti
Copy link
Contributor

@theocerutti theocerutti commented Sep 2, 2021 •
edited
Loading

screen
Screenshot from 2021-09-02 15-38-13

Closes: #3511

@theocerutti theocerutti requested a review from a team as a code owner September 2, 2021 13:34
@bert-e
Copy link
Contributor

bert-e commented Sep 2, 2021

Hello theocerutti,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Sep 2, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

ChengYanJin
ChengYanJin reviewed Sep 3, 2021
View reviewed changes
Copy link
Contributor

@ChengYanJin ChengYanJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment, I think we should have StartsAt field in the tooltip when the status is NOT healthy.

I am not sure if we should display the arrow, I will let @Cuervino answer the question ;)

ui/src/components/HealthItem.js Outdated Show resolved Hide resolved
ui/src/translations/fr.json Outdated Show resolved Hide resolved
ui/src/components/DashboardPlane.js Outdated Show resolved Hide resolved
ui/src/components/DashboardPlane.test.js Show resolved Hide resolved
ChengYanJin
ChengYanJin requested changes Sep 9, 2021
View reviewed changes
ui/src/components/DashboardPlane.test.js Show resolved Hide resolved
ui/src/components/HealthItem.js Outdated Show resolved Hide resolved
ui/src/components/HealthItem.js Outdated Show resolved Hide resolved
ui/src/components/DashboardPlane.js Show resolved Hide resolved
@bert-e
Copy link
Contributor

bert-e commented Sep 9, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@JulienMeziere JulienMeziere force-pushed the feature/ARTESCA-1878/dashboard-network-plane-health branch from 0f857a4 to 7a3b72f Compare September 15, 2021 09:49
ChengYanJin
ChengYanJin reviewed Sep 15, 2021
View reviewed changes
ui/webpack.common.js Outdated Show resolved Hide resolved
@JulienMeziere JulienMeziere force-pushed the feature/ARTESCA-1878/dashboard-network-plane-health branch from 7a3b72f to 25b81b3 Compare September 15, 2021 15:20
@JulienMeziere JulienMeziere force-pushed the feature/ARTESCA-1878/dashboard-network-plane-health branch from 25b81b3 to 65a3f18 Compare September 15, 2021 15:31
ChengYanJin
ChengYanJin previously approved these changes Sep 15, 2021
View reviewed changes
@bert-e
Copy link
Contributor

bert-e commented Sep 15, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JulienMeziere JulienMeziere force-pushed the feature/ARTESCA-1878/dashboard-network-plane-health branch from 70fadd0 to 74918e2 Compare September 17, 2021 15:05
@ChengYanJin ChengYanJin force-pushed the feature/ARTESCA-1878/dashboard-network-plane-health branch from 74918e2 to 466e6c5 Compare September 23, 2021 07:54
@ChengYanJin
ui/dashboard: Add network plane health in Network panel
4d7b149 
Remove the ServiceItem from DashboardServices and create the HealthItem component with it
Add DashboardPlane component containing 2 HealthItems
Add tests for the new DashbordPlane component
history.push replaced by history.replace in the HealthItem component

Ref: #3511
@ChengYanJin ChengYanJin force-pushed the feature/ARTESCA-1878/dashboard-network-plane-health branch from 466e6c5 to 4d7b149 Compare September 23, 2021 08:03
@JBWatenbergScality
Copy link
Contributor

Cherry-picked in #3501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBWatenbergScality JBWatenbergScality JBWatenbergScality left review comments

@JulienMeziere JulienMeziere JulienMeziere left review comments

@ChengYanJin ChengYanJin ChengYanJin approved these changes

@Cuervino Cuervino Awaiting requested review from Cuervino

Assignees

@JulienMeziere JulienMeziere

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MetalK8s UI Dashboard Network Plane Health
5 participants
@theocerutti @bert-e @JBWatenbergScality @ChengYanJin @JulienMeziere