UI - Bugfixes multi nodes - high availability #3521
Conversation
Hello jbwatenbergscality,My role is to assist you with the merge of this Status report is not available. |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list:
|
| const alertsNode = ((alertList && alertList.alerts) || []).filter( | ||
| (alert) => | ||
| alert.labels.instance === `${instanceIP}:${PORT_NODE_EXPORTER}` || | ||
| alert.labels.node === name, | ||
| ); |
There was a problem hiding this comment.
I am wondering why can't we add this filter within useAlerts() ?
const alertList = useAlerts({
alertname: NODE_ALERTS_GROUP,
instance: `${instanceIP}:${PORT_NODE_EXPORTER}`,
node: name
});There was a problem hiding this comment.
That would make an AND filter and then exclude the Alerts with label instance: ${instanceIP}:${PORT_NODE_EXPORTER} if the node label is not defined.
There was a problem hiding this comment.
Oh. Yes, that's right.. I miss the OR logic in the filter..
Look good to me then!
|
/approve |
Build failedThe build for commit did not succeed in branch w/2.11/bugfix/volume-info-retrieval. The following options are set: approve |
Build failedThe build for commit did not succeed in branch w/2.11/bugfix/volume-info-retrieval. The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue None. Goodbye jbwatenbergscality. |
Component:
UI
Context:
When a nodes is unavailable the UI reported wrong / incomplete information.