Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shell: Improve module federation performance #3469

Merged
merged 2 commits into from
Aug 5, 2021
Merged

shell: Improve module federation performance #3469

merged 2 commits into from
Aug 5, 2021

Conversation

JBWatenbergScality
Copy link
Contributor

Component:

Shell-UI

Context:

When switching between two federated apps in the navbar a loading screen is currently displayed.

image

Summary:

Around half of the time of this loading time is dedicated to loading remoteEntry chunk of the federated app. In order to improve navigation performance and reduce loading screen time, in this PR we prefetch remoteEntry chunks of apps for which we display a link in the navbar. The preloading is done in parallel of painting the current page and hence the impact on the app first paint time is negligible.

Acceptance criteria:

Loading screens while browsing federated apps are displayed for a shorter time.
In a dev env, where chunks are not optimised for production, we can see a 2x improvement on time spent on loading screen compared to the previous performance test using production optimised chunks.

image

@JBWatenbergScality
shell: Improve performance when switching between navbar entries by p…
f97b5b0 
…reloading remoteEntrie bundles and enabling react-query shared context
@JBWatenbergScality JBWatenbergScality requested a review from a team as a code owner August 2, 2021 08:36
@bert-e
Copy link
Contributor

bert-e commented Aug 2, 2021

Hello jbwatenbergscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Aug 2, 2021

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Aug 2, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

ChengYanJin
ChengYanJin approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@ChengYanJin ChengYanJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JBWatenbergScality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Aug 4, 2021

Build failed

The build for commit did not succeed in branch w/2.11/improvement/module-federation-navbar-navigation-perf-improvements.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Aug 4, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.10

  • ✔️ development/2.11

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Aug 5, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.10

  • ✔️ development/2.11

The following branches have NOT changed:

  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye jbwatenbergscality.

@bert-e bert-e merged commit d207129 into development/2.10 Aug 5, 2021
@bert-e bert-e deleted the improvement/module-federation-navbar-navigation-perf-improvements branch August 5, 2021 14:37
gdemonet added a commit that referenced this pull request Aug 5, 2021
@gdemonet
changelog: Update for 2.10.1 release
60f8cb3 
Refs: #3469
Refs: #3477
Refs: #3481
Refs: #3479
Refs: #3484
Refs: #3483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChengYanJin ChengYanJin ChengYanJin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JBWatenbergScality @bert-e @ChengYanJin