Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from stable Dex deprecated chart to Dex helm chart #3427

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Migrate from stable Dex deprecated chart to Dex helm chart #3427

merged 2 commits into from
Jun 29, 2021

Conversation

TeddyAndrieux
Copy link
Collaborator

@TeddyAndrieux TeddyAndrieux commented Jun 28, 2021 •
edited
Loading

The "stable/dex" helm chart get deprecated so we just move to the
supported one from Dex repo.

Manual patch in chart to add clusterIP support
See dexidp/helm-charts#48

Manual patch in chart to use HTTPS in the Ingress
See dexidp/helm-charts#15

Manual patch in chart to override checksum/config annotation
See dexidp/helm-charts#49

NOTE: We use kube-version 1.17 as curently we embed Python Kubernetes
1.17 version

@TeddyAndrieux
charts/render.py: Add support for kube-version
2026974 
In salt we still rely on an old version of python Kubernetes, so some
new object are not yet available in this version, in order to make
template generated by helm compatible with python-kubernetes version we
use we may need to change the `kube-version`.

NOTE: It's an ugly workaround waiting for a proper version of
python-kubernetes to be used or to have another way to manage Kubernetes
objects
@TeddyAndrieux TeddyAndrieux added complexity:easy Something that requires less than a day to fix kind:dependencies Pull requests that update a dependency file labels Jun 28, 2021
@TeddyAndrieux TeddyAndrieux requested a review from a team June 28, 2021 10:06
@bert-e
Copy link
Contributor

bert-e commented Jun 28, 2021

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jun 28, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@TeddyAndrieux
chart,salt: Migrate from "stable/dex" to "dex/dex" helm chart
bf3d93e 
The "stable/dex" helm chart get deprecated so we just move to the
supported one from Dex repo.

```
rm -rf charts/dex
helm repo add dex https://charts.dexidp.io
helm repo update
helm fetch -d charts --untar dex/dex
```

Patch chart to add clusterIP support
See dexidp/helm-charts#48

Patch chart to use HTTPS in the Ingress
See dexidp/helm-charts#15

Patch chart to be able to override `checksum/config` annotation
See dexidp/helm-charts#49

Render chart to salt state using:

```
./charts/render.py dex \
  --namespace metalk8s-auth charts/dex.yaml \
  --service-config dex metalk8s-dex-config \
  metalk8s/addons/dex/config/dex.yaml.j2 metalk8s-auth \
  --kube-version 1.17 charts/dex \
  > salt/metalk8s/addons/dex/deployed/chart.sls
```

NOTE: We use `kube-version 1.17` as curently we embed Python Kubernetes
1.17 version
@TeddyAndrieux
Copy link
Collaborator Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jun 29, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.10

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jun 29, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.10

The following branches have NOT changed:

  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye teddyandrieux.

@bert-e bert-e merged commit bf3d93e into development/2.10 Jun 29, 2021
@bert-e bert-e deleted the improvement/bump-dex branch June 29, 2021 07:15
@TeddyAndrieux TeddyAndrieux mentioned this pull request Jun 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-allard alexandre-allard alexandre-allard approved these changes

Assignees
No one assigned
Labels
complexity:easy Something that requires less than a day to fix kind:dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TeddyAndrieux @bert-e @alexandre-allard