-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
salt: Use systemd
cgroupdriver instead of cgroupfs
#3377
salt: Use systemd
cgroupdriver instead of cgroupfs
#3377
Conversation
Hello teddyandrieux,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list:
|
db5629c
to
5ffaa75
Compare
ConflictThere is a conflict between your branch Please resolve the conflict on the feature branch ( $ git fetch
$ git checkout origin/improvement/use-systemd-cgroup-for-kubelet
$ git merge origin/development/2.10
$ # <intense conflict resolution>
$ git commit
$ git push origin HEAD:improvement/use-systemd-cgroup-for-kubelet |
To match recommendation from Kubernetes/kubeadm, change the `cgroupDriver` from Kubelet to `systemd` and update containerd config file accordingly Sees: https://kubernetes.io/docs/setup/production-environment/container-runtimes/#containerd-systemd Fixes: #3366
5ffaa75
to
d7a71a4
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list:
|
/approve |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list:
The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue None. Goodbye teddyandrieux. |
Component:
'salt', 'kubelet', 'containerd'
Context:
#3366
Summary:
To match recommendation from Kubernetes/kubeadm, change the
cgroupDriver
from Kubelet tosystemd
and update containerd configfile accordingly
Sees: https://kubernetes.io/docs/setup/production-environment/container-runtimes/#containerd-systemd
Acceptance criteria:
This change only implies all containers to restart but that kind of behavior is already handled by the upgrade/downgrade process
Fixes: #3366