Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ingress-nginx chart version #3371

Merged
merged 4 commits into from
May 12, 2021
Merged

Bump ingress-nginx chart version #3371

merged 4 commits into from
May 12, 2021

Conversation

alexandre-allard
Copy link
Contributor

Component: salt, charts, build

Context:

Summary:
Bump ingress-nginx chart to version 3.30.0

Acceptance criteria:

See: #3279

@alexandre-allard alexandre-allard requested a review from a team as a code owner May 10, 2021 13:54
@bert-e
Copy link
Contributor

bert-e commented May 10, 2021

Hello alexandre-allard-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 10, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@alexandre-allard alexandre-allard added the kind:dependencies Pull requests that update a dependency file label May 10, 2021
@alexandre-allard alexandre-allard linked an issue May 10, 2021 that may be closed by this pull request
Bump Dependencies for MetalK8s 2.10 #3279
Closed
@alexandre-allard alexandre-allard changed the title Bump ingress-nginx Bump ingress-nginx chart version May 10, 2021
TeddyAndrieux
TeddyAndrieux previously approved these changes May 11, 2021
View reviewed changes
@alexandre-allard
charts: Bump nginx-ingress chart to 3.30.0
9815bec 
Update nginx-ingress chart using:
```
rm -rf charts/nginx-ingress
helm repo add ingress-nginx https://kubernetes.github.io/ingress-nginx
helm repo update
helm fetch -d charts --untar ingress-nginx/ingress-nginx
```

Refs: #3279
@alexandre-allard
build: Bump ingress-nginx image to v0.46.0
57770c6 
Needed by the update of the helm charts to
version 3.30.0

Refs: #3279
@alexandre-allard
salt: Re-render ingress-nginx Salt formulas
5e1122d 
Needed as we have bumped the Helm chart version
to 3.30.0, re-render using:

```
./charts/render.py ingress-nginx --namespace metalk8s-ingress \
  charts/ingress-nginx.yaml charts/ingress-nginx/ \
  > salt/metalk8s/addons/nginx-ingress/deployed/chart.sls
./charts/render.py ingress-nginx-control-plane --namespace metalk8s-ingress \
  charts/ingress-nginx-control-plane.yaml charts/ingress-nginx/ \
  > salt/metalk8s/addons/nginx-ingress-control-plane/deployed/chart.sls
```

Refs: #3279
@alexandre-allard
Add CHANGELOG entry for ingress-nginx version bump
be2e22f 
Refs: #3279
@alexandre-allard alexandre-allard force-pushed the improvement/3279-bump-ingress-nginx branch from 35c5b75 to be2e22f Compare May 11, 2021 19:03
@alexandre-allard
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented May 12, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.10

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 12, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.10

The following branches have NOT changed:

  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye alexandre-allard-scality.

@bert-e bert-e merged commit be2e22f into development/2.10 May 12, 2021
@bert-e bert-e deleted the improvement/3279-bump-ingress-nginx branch May 12, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeddyAndrieux TeddyAndrieux TeddyAndrieux approved these changes

Assignees
No one assigned
Labels
kind:dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump Dependencies for MetalK8s 2.10
3 participants
@alexandre-allard @bert-e @TeddyAndrieux