Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

salt: Allow to provide featureGates for apiserver in bootstrap config #3319

Merged
merged 2 commits into from
Apr 23, 2021
Merged

salt: Allow to provide featureGates for apiserver in bootstrap config #3319

merged 2 commits into from
Apr 23, 2021

Conversation

TeddyAndrieux
Copy link
Collaborator

Add ability to provide some feature gates for kube apiserver in
bootstrap config that will be persisted after upgrade/salt highstate ...

Fixes: #3294

@TeddyAndrieux TeddyAndrieux requested a review from a team April 23, 2021 16:19
@bert-e
Copy link
Contributor

bert-e commented Apr 23, 2021

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Apr 23, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

NicolasT
NicolasT suggested changes Apr 23, 2021
View reviewed changes
docs/installation/bootstrap.rst Outdated
The ``kubernetes`` field can be omitted if you do not have any specific
Kubernetes `Feature Gates`_ to enable or disable.

If you want to enable or disable a specific feature for ``kube-apiserver``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this indented?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to add several paragraphs for various "kubernetes" components in the future

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe should remove this indentation here since we will release this version with only apiserver

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed indentation here

@bert-e
Copy link
Contributor

bert-e commented Apr 23, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@TeddyAndrieux TeddyAndrieux force-pushed the improvement/allow-kube-apiserver-feature-gates-management branch 2 times, most recently from a2cfd89 to af1bd3c Compare April 23, 2021 16:49
@TeddyAndrieux TeddyAndrieux force-pushed the improvement/allow-kube-apiserver-feature-gates-management branch from af1bd3c to f69ece8 Compare April 23, 2021 17:05
gdemonet
gdemonet previously requested changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@gdemonet gdemonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close 😕

@bert-e
Copy link
Contributor

bert-e commented Apr 23, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@TeddyAndrieux
salt: Allow to provide featureGates for apiserver in bootstrap config
fbf45b9 
Add ability to provide some feature gates for kube apiserver in
bootstrap config that will be persisted after upgrade/salt highstate ...

Fixes: #3294
@TeddyAndrieux TeddyAndrieux force-pushed the improvement/allow-kube-apiserver-feature-gates-management branch from f69ece8 to fbf45b9 Compare April 23, 2021 18:08
NicolasT
NicolasT approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@NicolasT NicolasT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bert-e
Copy link
Contributor

bert-e commented Apr 23, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@NicolasT NicolasT requested a review from gdemonet April 23, 2021 19:03
@TeddyAndrieux
Copy link
Collaborator Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Apr 23, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Apr 23, 2021

Build failed

The build for commit did not succeed in branch improvement/allow-kube-apiserver-feature-gates-management.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Apr 23, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.9

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Apr 23, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.9

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8

Please check the status of the associated issue None.

Goodbye teddyandrieux.

@bert-e bert-e merged commit 7b84055 into development/2.9 Apr 23, 2021
@bert-e bert-e deleted the improvement/allow-kube-apiserver-feature-gates-management branch April 23, 2021 23:11
@TeddyAndrieux TeddyAndrieux mentioned this pull request Apr 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasT NicolasT NicolasT approved these changes

@gdemonet gdemonet Awaiting requested review from gdemonet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow configuration of kube-apiserver feature gates in BootstrapConfiguration
4 participants
@TeddyAndrieux @bert-e @NicolasT @gdemonet