Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

salt: Allow to provide featureGates for apiserver in bootstrap config #3318

Closed
wants to merge 2 commits into from
Closed

salt: Allow to provide featureGates for apiserver in bootstrap config #3318

wants to merge 2 commits into from

Conversation

TeddyAndrieux
Copy link
Collaborator

Add ability to provide some feature gates for kube apiserver in
bootstrap config that will be persisted after upgrade/salt highstate ...

Fixes: #3294

@TeddyAndrieux TeddyAndrieux requested a review from a team April 23, 2021 14:22
@bert-e
Copy link
Contributor

bert-e commented Apr 23, 2021

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Apr 23, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@TeddyAndrieux TeddyAndrieux force-pushed the improvement/allow-kube-apiserver-feature-gates-management branch from 6645fb1 to a4b00c2 Compare April 23, 2021 14:24
gdemonet
gdemonet suggested changes Apr 23, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
salt/_pillar/metalk8s.py Outdated Show resolved Hide resolved
@bert-e
Copy link
Contributor

bert-e commented Apr 23, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@bert-e
Copy link
Contributor

bert-e commented Apr 23, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@TeddyAndrieux
changelog: Fix missing pull link
a7d8771
@TeddyAndrieux
salt: Allow to provide featureGates for apiserver in bootstrap config
32832b9 
Add ability to provide some feature gates for kube apiserver in
bootstrap config that will be persisted after upgrade/salt highstate ...

Fixes: #3294
@TeddyAndrieux TeddyAndrieux force-pushed the improvement/allow-kube-apiserver-feature-gates-management branch from a4b00c2 to 32832b9 Compare April 23, 2021 15:14
@NicolasT
Copy link
Contributor

This likely needs a documentation entry as well.

@TeddyAndrieux
Copy link
Collaborator Author

This likely needs a documentation entry as well.

Do we really want to document it ?

@NicolasT
Copy link
Contributor

This likely needs a documentation entry as well.

Do we really want to document it ?

Yes since it's a feature. At least in the open source docs, maybe not in the product ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdemonet gdemonet gdemonet requested changes

@NicolasT NicolasT NicolasT requested changes

@alexandre-allard alexandre-allard alexandre-allard left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow configuration of kube-apiserver feature gates in BootstrapConfiguration
5 participants
@TeddyAndrieux @bert-e @NicolasT @alexandre-allard @gdemonet