Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetalK8s UI rebranding #3295

Merged
merged 44 commits into from
Apr 21, 2021
Merged

MetalK8s UI rebranding #3295

merged 44 commits into from
Apr 21, 2021

Conversation

ChengYanJin
Copy link
Contributor

@ChengYanJin ChengYanJin commented Apr 17, 2021 •
edited
Loading

Component: UI, theme

Context:
Rebranding

Summary:
In order to test this PR, need to update the core-ui with this branch:
#improvement/302-update-components-with-new-colors

Acceptance criteria:
image
image
image

Closes: #3291

@ChengYanJin ChengYanJin requested a review from a team as a code owner April 17, 2021 19:58
@ChengYanJin ChengYanJin force-pushed the improvement/3291-UI-rebranding branch from 0d0c9f6 to f5b4884 Compare April 17, 2021 20:54
@JBWatenbergScality JBWatenbergScality changed the base branch from improvement/rebranding to improvement/shell-ui-alert-provider April 18, 2021 07:48
@ChengYanJin ChengYanJin force-pushed the improvement/3291-UI-rebranding branch 3 times, most recently from bd05a92 to ddbbd86 Compare April 18, 2021 16:02
@JBWatenbergScality JBWatenbergScality changed the base branch from improvement/shell-ui-alert-provider to development/2.9 April 20, 2021 10:17
@bert-e
Copy link
Contributor

bert-e commented Apr 20, 2021

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Apr 20, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin ChengYanJin force-pushed the improvement/3291-UI-rebranding branch from 9022063 to a9e953b Compare April 20, 2021 10:42
@ChengYanJin
Copy link
Contributor Author

ChengYanJin commented Apr 20, 2021 •
edited
Loading

image

Review by Valamir. Post here to track.
Alerts

  1. Add a separation line between the header and the first line of the content
  2. Set the alignment of "Active since" on the right
  3. The date format should be "2021-04-18 21:44:25"
  4. Set general background-color to BackgroundLevel1
  5. The beginning of the Alert summary bar is too low. Currently it's 111px, it should be around 100px
  6. Cursor should be the action cursor, and not the "edit" cursor when hovering the header of the table.
  7. The notification pills should have the same size (height)
  8. The values should be aligned in the notification pills
  9. the space between the Summary component and the table container component should be 8px (it was not correct on the mockup screen design)

Yanjin:
The 3rd point hasn't been addressed yet. will do it in the next PR.

@ChengYanJin ChengYanJin force-pushed the improvement/3291-UI-rebranding branch from 849a7eb to 16b80be Compare April 20, 2021 16:02
JBWatenbergScality and others added 11 commits April 20, 2021 18:03
@JBWatenbergScality @ChengYanJin
shell-ui: Move bundles to sub folders
59da5f6
@JBWatenbergScality @ChengYanJin
shell-ui: Swith whatwg-fetch to node-fetch to polyfill fetch in node …
173a47d 
…(refs: mswjs/msw#448)
@JBWatenbergScality @ChengYanJin
shell-ui: Add env to start dev preview of alerts or navbar
959ad0a
@JBWatenbergScality @ChengYanJin
shell-ui: Add alert library
6725cf0
@JBWatenbergScality @ChengYanJin
shell-ui: fixup alert library
97d4df0
@JBWatenbergScality @ChengYanJin
ui: Use shell-ui alert library
f8db72d
@JBWatenbergScality @ChengYanJin
shell-ui: Add a getIdToken method on the navbar element to allow sync…
4f97dd2 
…hronization of elements mounted after the navbar
@ChengYanJin
shell-ui: Add alerthook and expose in library
e5a062d 
Refs: #3257
@ChengYanJin
shell-ui: Add k8s service
a33ef1c 
Check if the k8s call carry the `id_token`, otherwise listen to the
navbarElement AUTHENTICATED_EVENT

Refs: #3275
@ChengYanJin
shell-ui: Add test for getNodesCount
0b5967d 
Refs: #3257
@ChengYanJin
shell-ui: Add enabled option in query object
6791859 
To disable the query if token is not provided

Refs: #3257
JBWatenbergScality and others added 20 commits April 20, 2021 18:03
@JBWatenbergScality @ChengYanJin
ui: Fix core ui version
c1f169f
@JBWatenbergScality @ChengYanJin
ui: New alert page and enable alert filtering on annotations
0af5021
@ChengYanJin
ui/alertpage: Add the active alert table
641be64
@ChengYanJin
ui/layout: Render the new alertpage at /alerts
7fa4046
@JBWatenbergScality @ChengYanJin
ui: Add missing logo
0369683
@JBWatenbergScality @ChengYanJin
ui: Add dark rebrand logo
c7f4561
@JBWatenbergScality @ChengYanJin
ui: Hide the sidebar on alert page
c0547f4
@JBWatenbergScality @ChengYanJin
shell-ui: Improve default config
8bf6f28
@JBWatenbergScality @ChengYanJin
ui: Remove alerts sidebar test as we don't render anymore the alert p…
63c6c5d 
…age link in the sidebar
@ChengYanJin
ui/alertpage: Add sorting for the active alert table
293345d
@ChengYanJin
ui/alertpage: add searching
7b89c76
@ChengYanJin
ui: Add styled TextBadge
312c381
@JBWatenbergScality @ChengYanJin
ui: Fix alert page issue
86899e2
@JBWatenbergScality @ChengYanJin
shell-ui: Force lang to english when canChangeLanguage is disabled
6db6f81
@JBWatenbergScality @ChengYanJin
ui: Display summary when description is undefined in alert page
b5b4bb1
@ChengYanJin
shell-ui: Fix the regression of not remove the warning alert
8d777ae
@ChengYanJin
ui/alertpage: Polish the UI
657c971
@ChengYanJin
shell-ui: Exclude the parents label when removing the warning alert
ae7494a
@ChengYanJin
ui shell-ui: Update the core-ui version with v0.16.0
5ef2862
@ChengYanJin
ui: Fix the bug cause by the empty alertlist
16b80be
@ChengYanJin
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Apr 21, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Apr 21, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.9

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Apr 21, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.9

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8

Please check the status of the associated issue None.

Goodbye chengyanjin.

@bert-e bert-e merged commit 16b80be into development/2.9 Apr 21, 2021
@bert-e bert-e deleted the improvement/3291-UI-rebranding branch April 21, 2021 07:22
This was referenced Apr 21, 2021
Closed
Closed
@Cuervino Cuervino added the topic: discrepancy-ui ui-review topics label Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBWatenbergScality JBWatenbergScality JBWatenbergScality approved these changes

@MonPote MonPote Awaiting requested review from MonPote

@Cuervino Cuervino Awaiting requested review from Cuervino

@thomasdanan thomasdanan Awaiting requested review from thomasdanan

Assignees
No one assigned
Labels
topic: discrepancy-ui ui-review topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update color & layouts (padding and margin)
4 participants
@ChengYanJin @bert-e @JBWatenbergScality @Cuervino