Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Bump Node.js to LTS v14.16.0 #3214

Merged
merged 6 commits into from
Mar 22, 2021

Conversation

ChengYanJin
Copy link
Contributor

@ChengYanJin ChengYanJin commented Mar 19, 2021

Component: ui, dependency

Context:
Node is dropping maintenance support of v10 by the end of April and we are using this version to build UI projects.
We should bump the Node.js to the current LTS v14.16.0

Summary:

Acceptance criteria:
The UI should still work as before locally.
CI pass.


Closes: #3156

@ChengYanJin ChengYanJin requested a review from a team as a code owner March 19, 2021 14:33
@bert-e
Copy link
Contributor

bert-e commented Mar 19, 2021

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Mar 19, 2021

Branches have diverged

This pull request's source branch improvement/3156-bump-node-to-activeLTSv14 has diverged from
development/2.9 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

  • Merge origin/development/2.9 into improvement/3156-bump-node-to-activeLTSv14
  • Rebase improvement/3156-bump-node-to-activeLTSv14 onto origin/development/2.9

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

@ChengYanJin ChengYanJin changed the title [UI] Bump Node.js to active LTS v14 [UI] Bump Node.js to LTS v14.16.0 Mar 19, 2021
@ChengYanJin ChengYanJin force-pushed the improvement/3156-bump-node-to-activeLTSv14 branch from 09b00e1 to 6c7dbab Compare March 19, 2021 19:23
@bert-e
Copy link
Contributor

bert-e commented Mar 19, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Mar 22, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.9

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 22, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.9

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8

Please check the status of the associated issue None.

Goodbye chengyanjin.

@bert-e bert-e merged commit 8c0ef3e into development/2.9 Mar 22, 2021
@bert-e bert-e deleted the improvement/3156-bump-node-to-activeLTSv14 branch March 22, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui][ci] Bump Node.js to the Active LTS - v14
3 participants