Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: install qperf in metalk8s-utils #3174

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

NicolasT
Copy link
Contributor

@NicolasT NicolasT commented Mar 5, 2021

H/t to @scality-trevorbenson.

See: https://github.com/linux-rdma/qperf

@NicolasT NicolasT added kind:enhancement New feature or request topic:networking Networking-related issues topic:operations Operations-related issues complexity:easy Something that requires less than a day to fix release:nice to have An issue planned for a release which may be moved out if required topic:tooling Everything related to tooling around MetalK8s (e.g. Vagrant or Terraform) labels Mar 5, 2021
@NicolasT NicolasT requested a review from a team as a code owner March 5, 2021 17:23
@bert-e
Copy link
Contributor

bert-e commented Mar 5, 2021

Hello nicolast,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Mar 5, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@NicolasT
Copy link
Contributor Author

NicolasT commented Mar 6, 2021

/approve

@bert-e
Copy link
Contributor

bert-e commented Mar 6, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.9

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 6, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.9

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8

Please check the status of the associated issue None.

Goodbye nicolast.

@bert-e bert-e merged commit 65153d8 into development/2.9 Mar 6, 2021
@bert-e bert-e deleted the improvement/qperf-in-metalk8s-utils branch March 6, 2021 21:54
NicolasT added a commit that referenced this pull request Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:easy Something that requires less than a day to fix kind:enhancement New feature or request release:nice to have An issue planned for a release which may be moved out if required topic:networking Networking-related issues topic:operations Operations-related issues topic:tooling Everything related to tooling around MetalK8s (e.g. Vagrant or Terraform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants