Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore CI in offline mode #3151

Merged
merged 5 commits into from
Mar 15, 2021
Merged

Conversation

alexandre-allard
Copy link
Contributor

Component: ci

Context:
We found some bug lately (#3120), not catched by the CI, because we're no longer testing in offline environments since #1928.

Summary:
Restore the offline mode by configuring some security groups on Openstack and using a proxy for the YUM repositories.

Acceptance criteria:

@alexandre-allard alexandre-allard requested a review from a team as a code owner February 25, 2021 15:13
@bert-e
Copy link
Contributor

bert-e commented Feb 25, 2021

Hello alexandre-allard-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 25, 2021

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Feb 25, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

Copy link
Collaborator

@TeddyAndrieux TeddyAndrieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It seems RHEL8 does not work offline (don't know why just build status)

eve/workers/openstack-terraform/terraform/common.tf Outdated Show resolved Hide resolved
@alexandre-allard alexandre-allard force-pushed the bugfix/restore-ci-in-offline-mode branch from cef5b8c to 5639f7e Compare March 1, 2021 13:23
@bert-e
Copy link
Contributor

bert-e commented Mar 1, 2021

History mismatch

Merge commit #cef5b8ca7b0322d5562a7025931ceedcb3603057 on the integration branch
w/2.9/bugfix/restore-ci-in-offline-mode is merging a branch which is neither the current
branch bugfix/restore-ci-in-offline-mode nor the development branch
development/2.9.

It is likely due to a rebase of the branch bugfix/restore-ci-in-offline-mode and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

@alexandre-allard
Copy link
Contributor Author

/reset

@bert-e
Copy link
Contributor

bert-e commented Mar 1, 2021

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented Mar 1, 2021

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Mar 1, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@alexandre-allard alexandre-allard force-pushed the bugfix/restore-ci-in-offline-mode branch from 5639f7e to 1bd5815 Compare March 1, 2021 14:55
@bert-e
Copy link
Contributor

bert-e commented Mar 1, 2021

History mismatch

Merge commit #30b1b5cd1488e096c5533515f155a46b628ce636 on the integration branch
w/2.9/bugfix/restore-ci-in-offline-mode is merging a branch which is neither the current
branch bugfix/restore-ci-in-offline-mode nor the development branch
development/2.9.

It is likely due to a rebase of the branch bugfix/restore-ci-in-offline-mode and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

@alexandre-allard alexandre-allard force-pushed the bugfix/restore-ci-in-offline-mode branch 2 times, most recently from 5e86f25 to 534b3b4 Compare March 1, 2021 16:54
Copy link
Contributor

@gdemonet gdemonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for a small comment on disabling offline for RHEL 8, I think this is good to merge 🙂
Just wondering, how does this work with already existing snapshots which were not configured to run offline? (I guess it still works, but worth checking)

eve/main.yml Outdated Show resolved Hide resolved
@alexandre-allard alexandre-allard force-pushed the bugfix/restore-ci-in-offline-mode branch 2 times, most recently from 0be7f8c to 0fb606e Compare March 3, 2021 14:13
@bert-e
Copy link
Contributor

bert-e commented Mar 4, 2021

Branches have diverged

This pull request's source branch bugfix/restore-ci-in-offline-mode has diverged from
development/2.8 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

  • Merge origin/development/2.8 into bugfix/restore-ci-in-offline-mode
  • Rebase bugfix/restore-ci-in-offline-mode onto origin/development/2.8

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

@alexandre-allard
Copy link
Contributor Author

/reset

@bert-e
Copy link
Contributor

bert-e commented Mar 5, 2021

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented Mar 5, 2021

Branches have diverged

This pull request's source branch bugfix/restore-ci-in-offline-mode has diverged from
development/2.8 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

  • Merge origin/development/2.8 into bugfix/restore-ci-in-offline-mode
  • Rebase bugfix/restore-ci-in-offline-mode onto origin/development/2.8

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

@alexandre-allard alexandre-allard force-pushed the bugfix/restore-ci-in-offline-mode branch from 0fb606e to 7bb4c5e Compare March 5, 2021 11:19
@bert-e
Copy link
Contributor

bert-e commented Mar 5, 2021

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Mar 5, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

gdemonet
gdemonet previously approved these changes Mar 6, 2021
@alexandre-allard
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Mar 9, 2021

Build failed

The build for commit did not succeed in branch w/2.9/bugfix/restore-ci-in-offline-mode.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 11, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

Quoting keyword is now deprecated, so let's
get rid of these quotes.
We restore the offline mode to ensure we
check that everything is working offline
during CI runs.
The proxy is used only for yum repositories.

Proxy is disabled for RHEL system as there is
an issue with proxy and redhat certificates
@alexandre-allard alexandre-allard force-pushed the bugfix/restore-ci-in-offline-mode branch from 6a2a4b2 to 0088072 Compare March 12, 2021 08:18
@bert-e
Copy link
Contributor

bert-e commented Mar 12, 2021

History mismatch

Merge commit #5df8e6f4d45431c1a8be400baa7d631b9db54114 on the integration branch
w/2.9/bugfix/restore-ci-in-offline-mode is merging a branch which is neither the current
branch bugfix/restore-ci-in-offline-mode nor the development branch
development/2.9.

It is likely due to a rebase of the branch bugfix/restore-ci-in-offline-mode and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

@alexandre-allard
Copy link
Contributor Author

/reset

@bert-e
Copy link
Contributor

bert-e commented Mar 12, 2021

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 12, 2021

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 12, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 12, 2021

Build failed

The build for commit did not succeed in branch bugfix/restore-ci-in-offline-mode.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 12, 2021

Build failed

The build for commit did not succeed in branch w/2.9/bugfix/restore-ci-in-offline-mode.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 12, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.8

  • ✔️ development/2.9

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 15, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.8

  • ✔️ development/2.9

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7

Please check the status of the associated issue None.

Goodbye alexandre-allard-scality.

@bert-e bert-e merged commit 174d454 into development/2.8 Mar 15, 2021
@bert-e bert-e deleted the bugfix/restore-ci-in-offline-mode branch March 15, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants