Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI - Introduce a solutions navbar #3106

Merged
merged 2 commits into from
Feb 15, 2021
Merged

UI - Introduce a solutions navbar #3106

merged 2 commits into from
Feb 15, 2021

Conversation

JBWatenbergScality
Copy link
Contributor

Component:

ui

Context:

In order to simplifies authentication, theme, language and others common ui settings management accross metalk8s solutions, this PR introduces a common web component navbar providing those features.

For now this PR only focus on authentication feature.

@JBWatenbergScality
navbar: Init solutions navbar dev environment
2b78ff4 
It provides a web component navbar that solutions UIs can reuse to benefit from :
 - a centralized authentication method
 - a theme provider
 - a language provider
@JBWatenbergScality JBWatenbergScality requested a review from a team as a code owner February 10, 2021 15:29
@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2021

Hello jbwatenbergscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JBWatenbergScality JBWatenbergScality force-pushed the improvement/introduce-common-navbar branch 2 times, most recently from 08cf57d to f2af053 Compare February 12, 2021 11:34
@JBWatenbergScality JBWatenbergScality force-pushed the improvement/introduce-common-navbar branch from f2af053 to 18f0a53 Compare February 12, 2021 11:36
ChengYanJin
ChengYanJin approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@ChengYanJin ChengYanJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JBWatenbergScality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Feb 15, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.8

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 15, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.8

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7

Please check the status of the associated issue None.

Goodbye jbwatenbergscality.

@bert-e bert-e merged commit ae0835a into development/2.8 Feb 15, 2021
@bert-e bert-e deleted the improvement/introduce-common-navbar branch February 15, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChengYanJin ChengYanJin ChengYanJin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JBWatenbergScality @bert-e @ChengYanJin