-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade: Wait properly for containers to be "running" after bootstrap kubelet upgrade #3105
Upgrade: Wait properly for containers to be "running" after bootstrap kubelet upgrade #3105
Conversation
Hello teddyandrieux,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list:
|
84be703
to
149fb27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only few typos, otherwise LGTM.
After kubelet upgrade all static pod may restart, so we need to wait for some "useful" pods to be running before going further in the upgrade process. NOTE: That before this PR we already sleep 20 seconds, so this commit only add a proper check after this sleep
Time to time, especially on really slow platform, we got failure because salt state execution timeout. Increase salt-master default timeout to 20
149fb27
to
899af3d
Compare
Fixed 😃 |
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue None. Goodbye teddyandrieux. |
Component:
'lifecycle'
Context:
Improve robustness of the upgrade script
Summary:
After kubelet upgrade all static pod may restart, so we need to wait for
some "useful" pods to be running before going further in the upgrade
process.
NOTE: That before this PR we already sleep 20 seconds, so this commit
only add a proper check after this sleep