Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages: Do not include "base" package in "metalk8s-saltstack" repo #3083

Merged

Conversation

TeddyAndrieux
Copy link
Collaborator

Component:

'salt', 'packages'

Context:

#3075

Summary:

In saltstack repository we have a "base" directory containing package
available in RHEL/CentOs 7 "base" repositories, since MetalK8s already
rely on this "base" repository available on the host it does not make
sense to include those package as part of metalk8s-saltstack
repository, especially for RedHat that do not have the GPG key for
those "base" packages build by CentOS


Fixes: #3075

In saltstack repository we have a "base" directory containing package
available in RHEL/CentOs 7 "base" repositories, since MetalK8s already
rely on this "base" repository available on the host it does not make
sense to include those package as part of `metalk8s-saltstack`
repository, especially for RedHat that do not have the GPG key for
those "base" packages build by CentOS

Fixes: #3075
@TeddyAndrieux TeddyAndrieux requested a review from a team February 3, 2021 16:31
@bert-e
Copy link
Contributor

bert-e commented Feb 3, 2021

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 3, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

Copy link
Contributor

@alexandre-allard alexandre-allard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TeddyAndrieux
Copy link
Collaborator Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Feb 5, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.8

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 5, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.8

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7

Please check the status of the associated issue None.

Goodbye teddyandrieux.

@bert-e bert-e merged commit 75c9fcc into development/2.8 Feb 5, 2021
@bert-e bert-e deleted the bugfix/do-not-include-base-pkg-in-salt-repo branch February 5, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Salt installation fail if base package not installed on rhel
3 participants