Check for valid CA minion at the beginning of the bootstrap

[TeddyAndrieux]

Component:

'script', 'bootstrap'

Context:

When trying to install the bootstrap node and providing an invalid CA minion in the Bootstrap configuration file. Bootstrap script fail with not clear error about Salt-api unable to starts etc.

Summary:

Currently in the bootstrap we use the local node as bootstrap node and
also as CA minion, adding a check to be sure that the minion id provided
in the bootstrap config match the local minion id.
NOTE: This check is only part of the script and not somewhere else in
Salt, the CA:minion key inside the bootstrap configuration
is here for being able to install MetalK8s using another Salt minion
as CA (Which is to yet supported by the bootstrap script)

Acceptance criteria:

Output when providing invalid minion id as CA minion in bootstrap configuration

# /srv/scality/metalk8s-2.8.0-dev/bootstrap.sh 
> Determine the OS... done [0s]
> Checking that BootstrapConfiguration is present... done [0s]
> Pre-minion system tests... done [0s]
> Configure internal repositories... done [0s]
> Check mandatory packages presence... done [8s]
> Disabling Salt minion service... done [0s]
> Stopping Salt minion service... done [0s]
> Installing mandatory packages... done [0s]
> Configuring Salt minion to run in local mode... done [6s]
> Ensure archive is available... done [2s]
> Checking local node... fail [7s]

Failure while running step 'Checking local node'

Command: check_local_node

Output:

<< BEGIN >>
local:
    True
CA minion "bootstrap" from bootstrap configuration is not equal to the local minion id "test-bootstrap.novalocal", you need to either change the local minion id, either update the bootstrap configuration.
<< END >>

This script will now exit

---

[bert-e]

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• one peer

Peer approvals must include at least 1 approval from the following list:

• @jbertran

• @ChengYanJin

• @slaperche-scality

• @thomasdanan

• @lucieleonard

• @gdemonet

• @TeddyAndrieux

• @nootal

• @MonPote

• @tcarmet

• @sayf-eddine-scality

• @cmonfort

• @NicolasT

• @carlito-scality

• @alexandre-allard-scality

[bert-e]

Conflict

There is a conflict between your branch improvement/check-for-ca-minion and the
destination branch development/2.8.

Please resolve the conflict on the feature branch (improvement/check-for-ca-minion).

 $ git fetch
 $ git checkout origin/improvement/check-for-ca-minion
 $ git merge origin/development/2.8
 $ # <intense conflict resolution>
 $ git commit
 $ git push origin HEAD:improvement/check-for-ca-minion

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• one peer

Peer approvals must include at least 1 approval from the following list:

• @thomasdanan

• @alexandre-allard-scality

• @JBWatenbergScality

• @gdemonet

• @lucieleonard

• @ChengYanJin

• @TeddyAndrieux

• @NicolasT

[TeddyAndrieux]

/approve

[bert-e]

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

• ✔️ development/2.8

The following branches will NOT be impacted:

• development/1.0
• development/1.1
• development/1.2
• development/1.3
• development/2.0
• development/2.1
• development/2.2
• development/2.3
• development/2.4
• development/2.5
• development/2.6
• development/2.7

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

• Any commit you add on the source branch will trigger a new cycle after the
  current queue is merged.
• Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/2.8

The following branches have NOT changed:

• development/1.0
• development/1.1
• development/1.2
• development/1.3
• development/2.0
• development/2.1
• development/2.2
• development/2.3
• development/2.4
• development/2.5
• development/2.6
• development/2.7

Please check the status of the associated issue None.

Goodbye teddyandrieux.