charts,build: update `prometheus-adapter` to 2.10.1 #3007

TeddyAndrieux · 2021-01-04T17:28:48Z

Component:

'monitoring'

Summary:

Bump prometheus-adapter chart to 2.10.1

bert-e · 2021-01-04T17:28:50Z

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2021-01-04T17:28:54Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

gdemonet · 2021-01-05T08:46:01Z

salt/metalk8s/addons/prometheus-adapter/deployed/chart.sls

-  namespace: metalk8s-monitoring
+  namespace: kube-system


Why would this RoleBinding need to live in kube-system?

Answering my own question: prometheus-community/helm-charts@1a2157d

TeddyAndrieux · 2021-01-05T09:02:45Z

/approve

bert-e · 2021-01-05T09:23:08Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/bump-prometheus-adapter-to-2101 into
development/2.7
w/2.8/improvement/bump-prometheus-adapter-to-2101 will be merged into development/2.8

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e · 2021-01-05T09:23:12Z

History mismatch

Merge commit #02a68fa43cfd5099759b26627d310cc0783dea05 on the integration branch
w/2.8/improvement/bump-prometheus-adapter-to-2101 is merging a branch which is neither the current
branch improvement/bump-prometheus-adapter-to-2101 nor the development branch
development/2.8.

It is likely due to a rebase of the branch improvement/bump-prometheus-adapter-to-2101 and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

TeddyAndrieux · 2021-01-05T09:28:55Z

/reset

bert-e · 2021-01-05T09:29:02Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

bert-e · 2021-01-05T09:29:11Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/bump-prometheus-adapter-to-2101 into
development/2.7
w/2.8/improvement/bump-prometheus-adapter-to-2101 will be merged into development/2.8

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e · 2021-01-05T09:29:15Z

History mismatch

Merge commit #bb67ecea2dd2e16fcff5d43bda1400c778136695 on the integration branch
w/2.8/improvement/bump-prometheus-adapter-to-2101 is merging a branch which is neither the current
branch improvement/bump-prometheus-adapter-to-2101 nor the development branch
development/2.8.

It is likely due to a rebase of the branch improvement/bump-prometheus-adapter-to-2101 and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

Update the image downloaded in the buildchain for prometheus-adapter. Update the prometheus-adapter chart using: ``` rm -rf charts/prometheus-adapter/ helm repo add prometheus-community https://prometheus-community.github.io/helm-charts helm repo update helm fetch -d charts --untar prometheus-community/prometheus-adapter ``` And then re-rendering using: ``` ./charts/render.py prometheus-adapter --namespace metalk8s-monitoring \ charts/prometheus-adapter.yaml charts/prometheus-adapter/ \ > salt/metalk8s/addons/prometheus-adapter/deployed/chart.sls ```

bert-e · 2021-01-05T09:36:09Z

History mismatch

Merge commit #2de79b307a21274f80c6a0823c8076c36c97c90c on the integration branch
w/2.8/improvement/bump-prometheus-adapter-to-2101 is merging a branch which is neither the current
branch improvement/bump-prometheus-adapter-to-2101 nor the development branch
development/2.8.

It is likely due to a rebase of the branch improvement/bump-prometheus-adapter-to-2101 and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

TeddyAndrieux · 2021-01-05T09:36:13Z

/reset

bert-e · 2021-01-05T09:36:18Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

bert-e · 2021-01-05T09:36:26Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/bump-prometheus-adapter-to-2101 into
development/2.7
w/2.8/improvement/bump-prometheus-adapter-to-2101 will be merged into development/2.8

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e · 2021-01-05T09:36:27Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

bert-e · 2021-01-05T11:02:07Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.7
✔️ development/2.8

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2021-01-05T11:02:13Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.7
✔️ development/2.8

The following branches have NOT changed:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6

Please check the status of the associated issue None.

Goodbye teddyandrieux.

TeddyAndrieux added kind:debt Technical debt complexity:easy Something that requires less than a day to fix topic:monitoring Everything related to monitoring of services in a running cluster labels Jan 4, 2021

TeddyAndrieux requested a review from a team January 4, 2021 17:28

TeddyAndrieux force-pushed the improvement/bump-prometheus-adapter-to-2101 branch from f092966 to 2de79b3 Compare January 4, 2021 17:29

gdemonet previously approved these changes Jan 5, 2021

View reviewed changes

TeddyAndrieux dismissed gdemonet’s stale review via 1bf7421 January 5, 2021 09:36

TeddyAndrieux force-pushed the improvement/bump-prometheus-adapter-to-2101 branch from 2de79b3 to 1bf7421 Compare January 5, 2021 09:36

gdemonet approved these changes Jan 5, 2021

View reviewed changes

bert-e merged commit 1bf7421 into development/2.7 Jan 5, 2021

bert-e deleted the improvement/bump-prometheus-adapter-to-2101 branch January 5, 2021 11:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

charts,build: update `prometheus-adapter` to 2.10.1 #3007

charts,build: update `prometheus-adapter` to 2.10.1 #3007

TeddyAndrieux commented Jan 4, 2021

bert-e commented Jan 4, 2021

bert-e commented Jan 4, 2021

gdemonet Jan 5, 2021

gdemonet Jan 5, 2021

TeddyAndrieux commented Jan 5, 2021

bert-e commented Jan 5, 2021

bert-e commented Jan 5, 2021

TeddyAndrieux commented Jan 5, 2021

bert-e commented Jan 5, 2021

bert-e commented Jan 5, 2021

bert-e commented Jan 5, 2021

bert-e commented Jan 5, 2021

TeddyAndrieux commented Jan 5, 2021

bert-e commented Jan 5, 2021

bert-e commented Jan 5, 2021

bert-e commented Jan 5, 2021

bert-e commented Jan 5, 2021

bert-e commented Jan 5, 2021

charts,build: update prometheus-adapter to 2.10.1 #3007

charts,build: update prometheus-adapter to 2.10.1 #3007

Conversation

TeddyAndrieux commented Jan 4, 2021

bert-e commented Jan 4, 2021

Hello teddyandrieux,

bert-e commented Jan 4, 2021

Waiting for approval

gdemonet Jan 5, 2021

Choose a reason for hiding this comment

gdemonet Jan 5, 2021

Choose a reason for hiding this comment

TeddyAndrieux commented Jan 5, 2021

bert-e commented Jan 5, 2021

Integration data created

bert-e commented Jan 5, 2021

History mismatch

TeddyAndrieux commented Jan 5, 2021

bert-e commented Jan 5, 2021

Reset complete

bert-e commented Jan 5, 2021

Integration data created

bert-e commented Jan 5, 2021

History mismatch

bert-e commented Jan 5, 2021

History mismatch

TeddyAndrieux commented Jan 5, 2021

bert-e commented Jan 5, 2021

Reset complete

bert-e commented Jan 5, 2021

Integration data created

bert-e commented Jan 5, 2021

Waiting for approval

bert-e commented Jan 5, 2021

In the queue

bert-e commented Jan 5, 2021

charts,build: update `prometheus-adapter` to 2.10.1 #3007

charts,build: update `prometheus-adapter` to 2.10.1 #3007