Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] bump core ui to resolve memory leaks in vega chart component #2988

Merged
merged 1 commit into from
Jan 7, 2021
Merged

[UI] bump core ui to resolve memory leaks in vega chart component #2988

merged 1 commit into from
Jan 7, 2021

Conversation

JBWatenbergScality
Copy link
Contributor

Component:

VegaChart

See: scality/core-ui#214

@JBWatenbergScality JBWatenbergScality requested a review from a team as a code owner December 17, 2020 15:12
@bert-e
Copy link
Contributor

bert-e commented Dec 17, 2020

Hello jbwatenbergscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 17, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin ChengYanJin force-pushed the bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak branch from 678509f to 1b4a664 Compare December 23, 2020 08:24
@bert-e
Copy link
Contributor

bert-e commented Dec 23, 2020

Branches have diverged

This pull request's source branch bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak has diverged from
development/2.7 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

  • Merge origin/development/2.7 into bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak
  • Rebase bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak onto origin/development/2.7

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

ChengYanJin
ChengYanJin previously approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@ChengYanJin ChengYanJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the new release in core-ui (v0.6.0), I bump the version in MetalK8s with the tag.

@ChengYanJin ChengYanJin force-pushed the bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak branch from 1b4a664 to fdc1b6e Compare December 23, 2020 08:41
@bert-e
Copy link
Contributor

bert-e commented Dec 23, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

ChengYanJin
ChengYanJin previously approved these changes Dec 23, 2020
View reviewed changes
@ChengYanJin ChengYanJin force-pushed the bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak branch from fdc1b6e to 7694e40 Compare December 23, 2020 11:42
@JBWatenbergScality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Dec 23, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 5, 2021

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 5, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 5, 2021

History mismatch

Merge commit #20c05f7e0dbd59a39c11276540b4a89ffc95add9 on the integration branch
w/2.8/bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak is merging a branch which is neither the current
branch bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak nor the development branch
development/2.8.

It is likely due to a rebase of the branch bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

@ChengYanJin
Copy link
Contributor

/reset

@bert-e
Copy link
Contributor

bert-e commented Jan 5, 2021

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 5, 2021

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 5, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 5, 2021

History mismatch

Merge commit #db7c70967d81e3e523e68f5f6e510b370de65c6b on the integration branch
w/2.8/bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak is merging a branch which is neither the current
branch bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak nor the development branch
development/2.8.

It is likely due to a rebase of the branch bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

ChengYanJin
ChengYanJin previously approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@ChengYanJin ChengYanJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChengYanJin ChengYanJin force-pushed the bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak branch from 7694e40 to a0cbf04 Compare January 5, 2021 15:03
@bert-e
Copy link
Contributor

bert-e commented Jan 5, 2021

History mismatch

Merge commit #7694e409636d8e1d4f22e335f09293a5b1e2f4af on the integration branch
w/2.8/bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak is merging a branch which is neither the current
branch bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak nor the development branch
development/2.8.

It is likely due to a rebase of the branch bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

@ChengYanJin
Copy link
Contributor

/reset

@bert-e
Copy link
Contributor

bert-e commented Jan 5, 2021

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 5, 2021

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 5, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 5, 2021

History mismatch

Merge commit #a8b26e814a25e0bd1bf807a10a7bbf2c68afb107 on the integration branch
w/2.8/bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak is merging a branch which is neither the current
branch bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak nor the development branch
development/2.8.

It is likely due to a rebase of the branch bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

@ChengYanJin
Copy link
Contributor

/reset

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2021

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2021

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2021

History mismatch

Merge commit #069bf66327b39b100bb0d1363bbf98720a65b8ce on the integration branch
w/2.8/bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak is merging a branch which is neither the current
branch bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak nor the development branch
development/2.8.

It is likely due to a rebase of the branch bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

@ChengYanJin ChengYanJin force-pushed the bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak branch from a0cbf04 to 2526571 Compare January 6, 2021 10:17
@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2021

History mismatch

Merge commit #a0cbf04ac517f716e8933f07a9f338751a946bae on the integration branch
w/2.8/bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak is merging a branch which is neither the current
branch bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak nor the development branch
development/2.8.

It is likely due to a rebase of the branch bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

@ChengYanJin
Copy link
Contributor

/reset

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2021

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2021

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2021

Build failed

The build for commit did not succeed in branch bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 7, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.7

  • ✔️ development/2.8

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 7, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.7

  • ✔️ development/2.8

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6

Please check the status of the associated issue None.

Goodbye jbwatenbergscality.

@bert-e bert-e merged commit 2526571 into development/2.7 Jan 7, 2021
@bert-e bert-e deleted the bugfix/ui-bump-core-ui-to-fix-vega-comp-memory-leak branch January 7, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChengYanJin ChengYanJin ChengYanJin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JBWatenbergScality @bert-e @ChengYanJin