Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Batch volume creation #2980

Closed

Conversation

ChengYanJin
Copy link
Contributor

@ChengYanJin ChengYanJin commented Dec 14, 2020

Component: ui, volumes

Context:
We want to be able to batch create volume from UI.

Summary:
Note that:
For RawBlockDevice, the recommended path only happens with '/dev/vda', we will see later if
For SparseLoopDevice, the size of the batch volume are the same as the default one.

Acceptance criteria:

  1. The Default Volume Creation Form
    image

  2. Volume type RawBlockDevice batch creation
    image

  3. Volume type SparseLoopDevice batch creation. (From big HD screen)
    image


Closes: #2964

@bert-e
Copy link
Contributor

bert-e commented Dec 14, 2020

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 14, 2020

Conflict

There is a conflict between your branch improvement/2964-batch-volume-creation and the
destination branch development/2.6.

Please resolve the conflict on the feature branch (improvement/2964-batch-volume-creation).

 $ git fetch
 $ git checkout origin/improvement/2964-batch-volume-creation
 $ git merge origin/development/2.6
 $ # <intense conflict resolution>
 $ git commit
 $ git push origin HEAD:improvement/2964-batch-volume-creation

@ChengYanJin ChengYanJin force-pushed the improvement/2964-batch-volume-creation branch from 7c8dd1d to e04ef1e Compare December 14, 2020 10:27
@bert-e
Copy link
Contributor

bert-e commented Dec 14, 2020

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Dec 14, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin
Copy link
Contributor Author

Wrong target, will create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants