Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: exit in error when all terraform retries fail #2639

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

alexandre-allard
Copy link
Contributor

Component: ci

Context:

Summary:

Acceptance criteria:

@alexandre-allard alexandre-allard requested a review from a team as a code owner June 22, 2020 09:17
@bert-e

This comment has been minimized.

@bert-e

This comment has been minimized.

@bert-e

This comment has been minimized.

gdemonet
gdemonet previously approved these changes Jun 22, 2020
Copy link
Contributor

@gdemonet gdemonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, would be nice to have this feature at the Eve step level... Feel free to open a feature request on their side, see if they have ideas, or maybe even submit a PR.

@alexandre-allard
Copy link
Contributor Author

alexandre-allard commented Jun 22, 2020

Thanks, would be nice to have this feature at the Eve step level... Feel free to open a feature request on their side, see if they have ideas, or maybe even submit a PR.

Yes, it could be very cool ! I'll open an issue and if I have extra time at some point, will try to do it.

@alexandre-allard alexandre-allard force-pushed the bugfix/exit-in-error--when-all-retries-fail branch from 097c7ab to f47d370 Compare June 22, 2020 16:25
@bert-e

This comment has been minimized.

@alexandre-allard
Copy link
Contributor Author

/reset

@bert-e

This comment has been minimized.

@bert-e

This comment has been minimized.

@bert-e

This comment has been minimized.

@alexandre-allard
Copy link
Contributor Author

/approve

@bert-e

This comment has been minimized.

@bert-e

This comment has been minimized.

@bert-e
Copy link
Contributor

bert-e commented Jun 24, 2020

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.4

  • ✔️ development/2.5

  • ✔️ development/2.6

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jun 24, 2020

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.4

  • ✔️ development/2.5

  • ✔️ development/2.6

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3

Please check the status of the associated issue None.

Goodbye alexandre-allard-scality.

@bert-e bert-e merged commit 7408905 into development/2.4 Jun 24, 2020
@bert-e bert-e deleted the bugfix/exit-in-error--when-all-retries-fail branch June 24, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants