-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer deploy Solution UIs #2617
No longer deploy Solution UIs #2617
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
af8197c
to
6ed2ab8
Compare
This comment has been minimized.
This comment has been minimized.
/reset |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6ed2ab8
to
e9892aa
Compare
This comment has been minimized.
This comment has been minimized.
e9892aa
to
e31bebf
Compare
/reset |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed to merge this after the release |
Maybe target Also, can we make sure people involved agree with the "new" design? Naming a few: @MonPote @nicolas2bert @slaperche-scality @rachedbenmustapha |
@gdemonet since we already broke the Solutions with the new manifest... I thought we could do everything in the same version. :) |
Maybe... Better to ask than to hope 😜 |
e31bebf
to
c6959d0
Compare
This PR is now targeting |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add an entry in the CHANGELOG and then merge it :)
This comment has been minimized.
This comment has been minimized.
It is now the responsibility of the Solution Operators to deploy their UIs. We changed this so that the Solution framework is really minimalistic and Solution developers are free to deploy and manage the Solution UI how they want. Refs: #2581
Stop generating the ui_image section in the manifest since the Solution framework no longer handle the Solution UI deployment. Refs: #2581
Since the UI is optionnal and we no longer deploy it from the Solution framework, we do not want to check for its presence as it's not directly related to the Solution framework anymore. Plus, this test would break because the Example Solution has not been adapted yet to deploy its UI. Refs: #2581
Update architecture document and solution developer guide to remove the part related to the deployment of Solution UIs because we no longer deploy them. Refs: #2581
c6959d0
to
56a6742
Compare
This comment has been minimized.
This comment has been minimized.
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue None. Goodbye alexandre-allard-scality. |
Component: salt, solutions, examples
Context: See #2581
Summary:
Solution UIs are no longer deployed by the Solution framework
Acceptance criteria:
Solution tests should be green.
Closes: #2581