docs: Remove old bootstrap node before restoration #2562

TeddyAndrieux · 2020-05-19T14:34:49Z

Component:

bootstrap restore

Summary:

Install kubectl on all master nodes
Add documentation to delete old bootstrap node before restoration

It may be need to interract with apiserver from master nodes, for example if bootstrap node is unreachable or ... what ever. So add `kubectl` salt states for master role

bert-e · 2020-05-19T14:34:51Z

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2020-05-19T14:34:54Z

Branches have diverged

This pull request's source branch bugfix/GH-2561-clean-bootstrap-pods-in-restore has diverged from
development/2.6 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

Merge origin/development/2.6 into bugfix/GH-2561-clean-bootstrap-pods-in-restore
Rebase bugfix/GH-2561-clean-bootstrap-pods-in-restore onto origin/development/2.6

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

bert-e · 2020-05-19T14:35:10Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/GH-2561-clean-bootstrap-pods-in-restore into
development/2.4
w/2.5/bugfix/GH-2561-clean-bootstrap-pods-in-restore will be merged into development/2.5
w/2.6/bugfix/GH-2561-clean-bootstrap-pods-in-restore will be merged into development/2.6

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2020-05-19T14:35:12Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

gdemonet

Some wording changes, but OK with the idea 👌

docs/operation/bootstrap_backup_restore.rst

bert-e · 2020-05-19T15:06:29Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@gdemonet

When restoring bootstrap, as we do not support multi-bootstrap right now we need to remove the old one before performing the restoration, it's a bit dangerous to remove this automaticaly from the restore script so just add documentation to do it Fixes: #2561

bert-e · 2020-05-19T15:22:13Z

History mismatch

Merge commit #f436758486ae4b45b0183df421b88cfe3386c2ec on the integration branch
w/2.5/bugfix/GH-2561-clean-bootstrap-pods-in-restore is merging a branch which is neither the current
branch bugfix/GH-2561-clean-bootstrap-pods-in-restore nor the development branch
development/2.5.

It is likely due to a rebase of the branch bugfix/GH-2561-clean-bootstrap-pods-in-restore and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

TeddyAndrieux · 2020-05-19T15:23:46Z

/reset

bert-e · 2020-05-19T15:23:54Z

Reset complete

I have successfully deleted this pull request's integration branches.

bert-e · 2020-05-19T15:24:04Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/GH-2561-clean-bootstrap-pods-in-restore into
development/2.4
w/2.5/bugfix/GH-2561-clean-bootstrap-pods-in-restore will be merged into development/2.5
w/2.6/bugfix/GH-2561-clean-bootstrap-pods-in-restore will be merged into development/2.6

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2020-05-19T15:24:06Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@gdemonet

bert-e · 2020-05-19T15:26:33Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

TeddyAndrieux · 2020-05-19T17:27:01Z

/approve

bert-e · 2020-05-19T17:35:31Z

Build failed

The build for commit did not succeed in branch w/2.6/bugfix/GH-2561-clean-bootstrap-pods-in-restore.

The following options are set: approve

bert-e · 2020-05-19T17:36:58Z

Build failed

The build for commit did not succeed in branch bugfix/GH-2561-clean-bootstrap-pods-in-restore.

The following options are set: approve

bert-e · 2020-05-19T18:06:07Z

Build failed

The build for commit did not succeed in branch w/2.6/bugfix/GH-2561-clean-bootstrap-pods-in-restore.

The following options are set: approve

bert-e · 2020-05-19T18:14:54Z

Build failed

The build for commit did not succeed in branch bugfix/GH-2561-clean-bootstrap-pods-in-restore.

The following options are set: approve

bert-e · 2020-05-19T21:50:32Z

Build failed

The build for commit did not succeed in branch w/2.5/bugfix/GH-2561-clean-bootstrap-pods-in-restore.

The following options are set: approve

bert-e · 2020-05-20T08:50:23Z

Build failed

The build for commit did not succeed in branch w/2.6/bugfix/GH-2561-clean-bootstrap-pods-in-restore.

The following options are set: approve

bert-e · 2020-05-20T09:47:25Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.4
✔️ development/2.5
✔️ development/2.6

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2020-05-20T13:13:44Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.4
✔️ development/2.5
✔️ development/2.6

The following branches have NOT changed:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

Please check the status of the associated issue GH-2561.

Goodbye teddyandrieux.

salt: Install kubectl on every master nodes

e51b55e

It may be need to interract with apiserver from master nodes, for example if bootstrap node is unreachable or ... what ever. So add `kubectl` salt states for master role

TeddyAndrieux requested a review from a team May 19, 2020 14:34

TeddyAndrieux changed the base branch from development/2.6 to development/2.4 May 19, 2020 14:34

gdemonet suggested changes May 19, 2020

View reviewed changes

TeddyAndrieux force-pushed the bugfix/GH-2561-clean-bootstrap-pods-in-restore branch from f436758 to ab89db6 Compare May 19, 2020 15:22

gdemonet approved these changes May 19, 2020

View reviewed changes

bert-e merged commit b16c113 into development/2.4 May 20, 2020

bert-e deleted the bugfix/GH-2561-clean-bootstrap-pods-in-restore branch May 20, 2020 13:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Remove old bootstrap node before restoration #2562

docs: Remove old bootstrap node before restoration #2562

TeddyAndrieux commented May 19, 2020

bert-e commented May 19, 2020

bert-e commented May 19, 2020

bert-e commented May 19, 2020

bert-e commented May 19, 2020

gdemonet left a comment

bert-e commented May 19, 2020

bert-e commented May 19, 2020

TeddyAndrieux commented May 19, 2020

bert-e commented May 19, 2020

bert-e commented May 19, 2020

bert-e commented May 19, 2020

bert-e commented May 19, 2020

TeddyAndrieux commented May 19, 2020

bert-e commented May 19, 2020

bert-e commented May 19, 2020

bert-e commented May 19, 2020

bert-e commented May 19, 2020

bert-e commented May 19, 2020

bert-e commented May 20, 2020

bert-e commented May 20, 2020

bert-e commented May 20, 2020

docs: Remove old bootstrap node before restoration #2562

docs: Remove old bootstrap node before restoration #2562

Conversation

TeddyAndrieux commented May 19, 2020

bert-e commented May 19, 2020

Hello teddyandrieux,

bert-e commented May 19, 2020

Branches have diverged

bert-e commented May 19, 2020

Integration data created

bert-e commented May 19, 2020

Waiting for approval

gdemonet left a comment

Choose a reason for hiding this comment

bert-e commented May 19, 2020

Waiting for approval

bert-e commented May 19, 2020

History mismatch

TeddyAndrieux commented May 19, 2020

bert-e commented May 19, 2020

Reset complete

bert-e commented May 19, 2020

Integration data created

bert-e commented May 19, 2020

Waiting for approval

bert-e commented May 19, 2020

Waiting for approval

TeddyAndrieux commented May 19, 2020

bert-e commented May 19, 2020

Build failed

bert-e commented May 19, 2020

Build failed

bert-e commented May 19, 2020

Build failed

bert-e commented May 19, 2020

Build failed

bert-e commented May 19, 2020

Build failed

bert-e commented May 20, 2020

Build failed

bert-e commented May 20, 2020

In the queue

bert-e commented May 20, 2020