Bump prometheus-operator version to 8.13.0 #2557

Ebaneck · 2020-05-18T17:18:54Z

Component:

'charts', 'prometheus-operator'

Context:

Summary:

Now, that the python-kubernetes version has been updated, we can proceed
with the chart upgrade.

The following issue #2430 (comment) raised previously while upgrading the charts should have been fixed after the python-kubernetes version was bumped.

Acceptance criteria:

Green build

Closes: #2430

bert-e · 2020-05-18T17:18:56Z

Hello ebaneck,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2020-05-18T17:19:05Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/2430-bump-prometheus-operator-version-to-8.13.0 into
development/2.5
w/2.6/improvement/2430-bump-prometheus-operator-version-to-8.13.0 will be merged into development/2.6

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

Ebaneck · 2020-05-18T17:19:06Z

/approve

bert-e · 2020-05-18T17:19:07Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2020-05-18T17:19:14Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

gdemonet · 2020-05-19T08:30:16Z

Would need to regenerate the deployed rules with what you defined in #2538. ~~We need a test to enforce this (otherwise the tooling has close to no purpose)~~ Edit: didn't see #2546.

gdemonet · 2020-05-19T08:45:55Z

/after_pull_request=2546

bert-e · 2020-05-19T08:45:58Z

Waiting for other pull request(s)

The current pull request is locked by the after_pull_request option.

In order for me to merge this pull request, run the following actions first:

➡️ Merge the OPEN pull request:

pull request tests: Add tests to validate Prometheus (deployed alerting rules == default alerting rules) #2546

Alternatively, delete all the after_pull_request comments from this pull request.

The following options are set: approve, after_pull_request

This chart is updated using: ``` $ rm -rf charts/prometheus-operator $ helm repo update $ helm fetch -d charts --untar stable/prometheus-operator $ ./charts/render.py prometheus-operator --namespace metalk8s-monitoring charts/prometheus-operator.yaml --service-config grafana metalk8s-grafana-config --service-config prometheus metalk8s-prometheus-config --service-config alertmanager metalk8s-alertmanager-config charts/prometheus-operator/ > salt/metalk8s/addons/prometheus-operator/deployed/chart.sls ```

Since we have updated the version of the prometheus-operator chart to version 8.13.0, we need to bump the versions of it's component in the buildchain ``` The following components now run with version numbers: Prometheus-operator => 0.38.1 Prometheus-config-reloader => 0.38.1 Prometheus => 2.16.0 kube-state-metrics => 1.9.5 Alertmanager => 0.20.0 Grafana => 6.7.1 ``` Closes: #2430

Grafana app labels have changed from `app=grafana` to `app.kubernetes.io/name=grafana` and so we need to make this changes.

Since we are updating the Prometheus-operator charts to `8.13.0`, we indeed check and document the new rules by running the rule_extractor python script and save the new changes introduced.

Ebaneck · 2020-05-22T22:40:04Z

/reset

bert-e · 2020-05-24T11:25:18Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: after_pull_request, approve

Ebaneck · 2020-05-26T21:36:45Z

/status

bert-e · 2020-05-26T21:36:47Z

Status

Status report is not available.

The following options are set: after_pull_request, approve

bert-e · 2020-05-26T21:36:55Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: after_pull_request, approve

bert-e · 2020-05-27T06:46:09Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.5
✔️ development/2.6

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: after_pull_request, approve

bert-e · 2020-05-27T13:12:33Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.5
✔️ development/2.6

The following branches have NOT changed:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4

Please check the status of the associated issue None.

Goodbye ebaneck.

Ebaneck requested a review from a team May 18, 2020 17:18

Ebaneck added 4 commits May 22, 2020 20:41

tests: fix Grafana app labels within the BDD feature

348a399

Grafana app labels have changed from `app=grafana` to `app.kubernetes.io/name=grafana` and so we need to make this changes.

Prometheus-operator: generate and document new Prometheus rules

f8ac04f

Since we are updating the Prometheus-operator charts to `8.13.0`, we indeed check and document the new rules by running the rule_extractor python script and save the new changes introduced.

Ebaneck force-pushed the improvement/2430-bump-prometheus-operator-version-to-8.13.0 branch from 4b5a32c to f8ac04f Compare May 22, 2020 18:48

scality deleted a comment from bert-e May 26, 2020

alexandre-allard approved these changes May 27, 2020

View reviewed changes

bert-e merged commit c839cef into development/2.5 May 27, 2020

bert-e deleted the improvement/2430-bump-prometheus-operator-version-to-8.13.0 branch May 27, 2020 13:12

TeddyAndrieux mentioned this pull request May 28, 2020

Upgrade downgrade in dev/2.5 is broken #2579

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump prometheus-operator version to 8.13.0 #2557

Bump prometheus-operator version to 8.13.0 #2557

Ebaneck commented May 18, 2020

bert-e commented May 18, 2020

bert-e commented May 18, 2020

Ebaneck commented May 18, 2020

bert-e commented May 18, 2020

bert-e commented May 18, 2020

gdemonet commented May 19, 2020 •

edited

Loading

gdemonet commented May 19, 2020

bert-e commented May 19, 2020

Ebaneck commented May 22, 2020

bert-e commented May 24, 2020

Ebaneck commented May 26, 2020

bert-e commented May 26, 2020

bert-e commented May 26, 2020

bert-e commented May 27, 2020

bert-e commented May 27, 2020

Bump prometheus-operator version to 8.13.0 #2557

Bump prometheus-operator version to 8.13.0 #2557

Conversation

Ebaneck commented May 18, 2020

bert-e commented May 18, 2020

Hello ebaneck,

bert-e commented May 18, 2020

Integration data created

Ebaneck commented May 18, 2020

bert-e commented May 18, 2020

Waiting for approval

bert-e commented May 18, 2020

Waiting for approval

gdemonet commented May 19, 2020 • edited Loading

gdemonet commented May 19, 2020

bert-e commented May 19, 2020

Waiting for other pull request(s)

Ebaneck commented May 22, 2020

bert-e commented May 24, 2020

Waiting for approval

Ebaneck commented May 26, 2020

bert-e commented May 26, 2020

Status

bert-e commented May 26, 2020

Waiting for approval

bert-e commented May 27, 2020

In the queue

bert-e commented May 27, 2020

gdemonet commented May 19, 2020 •

edited

Loading