UI: Bugfix - provision volumes with labels #2066

carlito-scality · 2019-11-22T09:19:14Z

Component: UI

Context:

We need to add labels in the templates instead of the Volume object itself when creating volumes so labels can be propagated to PersistentVolume.

Summary:

Acceptance criteria:

Closes: #1891

bert-e · 2019-11-22T09:19:17Z

Hello carlito-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2019-11-22T09:19:23Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/provision_volumes_with_labels into
development/2.4
w/2.5/bugfix/provision_volumes_with_labels will be merged into development/2.5

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2019-11-22T09:19:25Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

ChengYanJin

LGTM

gdemonet · 2019-11-22T13:47:01Z

ui/src/ducks/app/volumes.js

@@ -212,11 +212,15 @@ export function* createVolumes({ payload }) {
    kind: 'Volume',
    metadata: {
      name: newVolume.name,
-      labels: newVolume.labels,


No, keep it

bert-e · 2019-11-22T13:47:13Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@gdemonet

bert-e · 2019-12-03T16:27:35Z

History mismatch

Merge commit #94bed350fee2418e8e0c3118a630a0d7452f82f1 on the integration branch
w/2.5/bugfix/provision_volumes_with_labels is merging a branch which is neither the current
branch bugfix/provision_volumes_with_labels nor the development branch
development/2.5.

It is likely due to a rebase of the branch bugfix/provision_volumes_with_labels and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

carlito-scality · 2019-12-05T10:11:52Z

/reset

bert-e · 2019-12-05T10:11:59Z

Reset complete

I have successfully deleted this pull request's integration branches.

bert-e · 2019-12-05T10:12:06Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/provision_volumes_with_labels into
development/2.4
w/2.5/bugfix/provision_volumes_with_labels will be merged into development/2.5

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2019-12-05T10:12:08Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@gdemonet

…f Volume when creating so labels can be set correctly in PersistentVolume. - Display the peristentVolume labels instead of Volume labels ifself

- Add cypress-wait-until library to check the volume avaibility by retrying the status check - Fix Volume SparseLoopDevice failed status due to the size problem

bert-e · 2019-12-05T14:43:19Z

History mismatch

Merge commit #aa709d0669bec793ebafc64eda377e2180950545 on the integration branch
w/2.5/bugfix/provision_volumes_with_labels is merging a branch which is neither the current
branch bugfix/provision_volumes_with_labels nor the development branch
development/2.5.

It is likely due to a rebase of the branch bugfix/provision_volumes_with_labels and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

carlito-scality · 2019-12-05T14:48:38Z

/reset

bert-e · 2019-12-05T14:48:45Z

Reset complete

I have successfully deleted this pull request's integration branches.

bert-e · 2019-12-05T14:49:00Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/provision_volumes_with_labels into
development/2.4
w/2.5/bugfix/provision_volumes_with_labels will be merged into development/2.5

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2019-12-05T14:49:02Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@gdemonet

- cypress-wait-until is required to launch cypress tests

carlito-scality · 2019-12-09T16:02:09Z

/approve

bert-e · 2019-12-09T16:02:16Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@gdemonet

The following options are set: approve

bert-e · 2019-12-09T22:55:07Z

Build failed

The build for commit did not succeed in branch w/2.5/bugfix/provision_volumes_with_labels.

The following options are set: approve

bert-e · 2019-12-10T18:44:31Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.4
✔️ development/2.5

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2019-12-10T19:47:28Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.4
✔️ development/2.5

The following branches have NOT changed:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

Please check the status of the associated issue None.

Goodbye carlito-scality.

carlito-scality added kind:bug Something isn't working moonshot topic:ui UI-related issues complexity:easy Something that requires less than a day to fix labels Nov 22, 2019

carlito-scality requested a review from a team as a code owner November 22, 2019 09:19

ChengYanJin previously approved these changes Nov 22, 2019

View reviewed changes

gdemonet suggested changes Nov 22, 2019

View reviewed changes

carlito-scality dismissed ChengYanJin’s stale review via b161c4f December 3, 2019 16:27

carlito-scality force-pushed the bugfix/provision_volumes_with_labels branch from b43f44e to b161c4f Compare December 3, 2019 16:27

carlito-scality force-pushed the bugfix/provision_volumes_with_labels branch from bd502bd to 0c0b76c Compare December 5, 2019 10:09

carlito-scality requested review from gdemonet and ChengYanJin December 5, 2019 10:12

carlito-scality added 3 commits December 5, 2019 15:40

UI: Provision volumes with labels - Pass the labels in the template o…

5aaf7cc

…f Volume when creating so labels can be set correctly in PersistentVolume. - Display the peristentVolume labels instead of Volume labels ifself

UI: make labels visible on Dark Mode when creating volumes

1191295

Cypress tests: update volume creation tests

e202c88

- Add cypress-wait-until library to check the volume avaibility by retrying the status check - Fix Volume SparseLoopDevice failed status due to the size problem

carlito-scality force-pushed the bugfix/provision_volumes_with_labels branch from 0c0b76c to e202c88 Compare December 5, 2019 14:43

UI: install cypress-wait-until in cypress.sh

dd930e0

- cypress-wait-until is required to launch cypress tests

ChengYanJin approved these changes Dec 9, 2019

View reviewed changes

gdemonet approved these changes Dec 9, 2019

View reviewed changes

bert-e merged commit dd930e0 into development/2.4 Dec 10, 2019

bert-e deleted the bugfix/provision_volumes_with_labels branch December 10, 2019 19:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI: Bugfix - provision volumes with labels #2066

UI: Bugfix - provision volumes with labels #2066

carlito-scality commented Nov 22, 2019

bert-e commented Nov 22, 2019

bert-e commented Nov 22, 2019

bert-e commented Nov 22, 2019

ChengYanJin left a comment

gdemonet Nov 22, 2019

bert-e commented Nov 22, 2019

bert-e commented Dec 3, 2019

carlito-scality commented Dec 5, 2019

bert-e commented Dec 5, 2019

bert-e commented Dec 5, 2019

bert-e commented Dec 5, 2019

bert-e commented Dec 5, 2019

carlito-scality commented Dec 5, 2019

bert-e commented Dec 5, 2019

bert-e commented Dec 5, 2019

bert-e commented Dec 5, 2019

carlito-scality commented Dec 9, 2019

bert-e commented Dec 9, 2019

bert-e commented Dec 9, 2019

bert-e commented Dec 10, 2019

bert-e commented Dec 10, 2019

UI: Bugfix - provision volumes with labels #2066

UI: Bugfix - provision volumes with labels #2066

Conversation

carlito-scality commented Nov 22, 2019

bert-e commented Nov 22, 2019

Hello carlito-scality,

bert-e commented Nov 22, 2019

Integration data created

bert-e commented Nov 22, 2019

Waiting for approval

ChengYanJin left a comment

Choose a reason for hiding this comment

gdemonet Nov 22, 2019

Choose a reason for hiding this comment

bert-e commented Nov 22, 2019

Waiting for approval

bert-e commented Dec 3, 2019

History mismatch

carlito-scality commented Dec 5, 2019

bert-e commented Dec 5, 2019

Reset complete

bert-e commented Dec 5, 2019

Integration data created

bert-e commented Dec 5, 2019

Waiting for approval

bert-e commented Dec 5, 2019

History mismatch

carlito-scality commented Dec 5, 2019

bert-e commented Dec 5, 2019

Reset complete

bert-e commented Dec 5, 2019

Integration data created

bert-e commented Dec 5, 2019

Waiting for approval

carlito-scality commented Dec 9, 2019

bert-e commented Dec 9, 2019

Waiting for approval

bert-e commented Dec 9, 2019

Build failed

bert-e commented Dec 10, 2019

In the queue

bert-e commented Dec 10, 2019