Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metalk8s-sosreport package is not compatible with latest sos 4.0.0+ versions #3387

Closed
alexandre-allard opened this issue May 18, 2021 · 0 comments · Fixed by #3388 or #3664
Closed

metalk8s-sosreport package is not compatible with latest sos 4.0.0+ versions #3387

alexandre-allard opened this issue May 18, 2021 · 0 comments · Fixed by #3388 or #3664
Assignees
@alexandre-allard @TeddyAndrieux
Labels
kind:bug Something isn't working

Comments

@alexandre-allard
Copy link
Contributor

Component: packages

What happened:
In the CI, we are unable to successfully run the sosreport step for RHEL 8

What was expected:
Report is generated successfully.

Steps to reproduce:
Launch a build and wait for the single-node-install rhel stage to fail.

Resolution proposal (optional):
First, we can fix the sos version needed to an older version, but in a near future we may want to be compatible with sos 4.0.0+ versions.
@alexandre-allard alexandre-allard added the kind:bug Something isn't working label May 18, 2021
alexandre-allard added a commit that referenced this issue May 18, 2021
@alexandre-allard
packages: force sos dependency on an older version
a6978fe 
For now, we stick to a version before 4.0.0 as
it is not compatible with this one.

Refs: #3387
@alexandre-allard alexandre-allard mentioned this issue May 18, 2021
Merged
@alexandre-allard alexandre-allard self-assigned this May 18, 2021
alexandre-allard added a commit that referenced this issue May 19, 2021
@alexandre-allard
build,salt: allow to pass a version constraint for packages
1acbec6 
Instead of passing the exact version, we can now provide
a constraint (<, >, <=, >=) if we don't need a specific
version but we want to exclude some.

Refs: #3387
alexandre-allard added a commit that referenced this issue May 19, 2021
@alexandre-allard
build,salt: allow to pass a version constraint for packages
96ab5de 
Instead of passing the exact version, we can now provide
a constraint (<, >, <=, >=) if we don't need a specific
version but we want to exclude some.

Refs: #3387
alexandre-allard added a commit that referenced this issue May 19, 2021
@alexandre-allard
build,salt: allow to pass a version constraint for packages
8bfdfc7 
Instead of passing the exact version, we can now provide
a constraint (<, >, <=, >=) if we don't need a specific
version but we want to exclude some.

Refs: #3387
@alexandre-allard alexandre-allard linked a pull request May 20, 2021 that will close this issue
Force sos dependency on an older version #3388
Merged
TeddyAndrieux added a commit that referenced this issue Jan 13, 2022
@TeddyAndrieux
packages: Make our sosreport package compatible with new sos version
14fdfaa 
Since sos layout changed in 4.0 and CentOS 7 does not have this sos
version available by default, so we need some logic in the packages
in order to be compatible with sos > 4.0 and sos < 4.0.

We enforce sos < 4.0 for CentOS/RHEL 7 and sos >= 4.0 for RHEL8

Fixes: #3387
@TeddyAndrieux TeddyAndrieux self-assigned this Jan 13, 2022
@TeddyAndrieux TeddyAndrieux mentioned this issue Jan 14, 2022
Merged
@bert-e bert-e closed this as completed in 06fa3a7 Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexandre-allard alexandre-allard

@TeddyAndrieux TeddyAndrieux

Labels
kind:bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@alexandre-allard @TeddyAndrieux