Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: shared styled components classnames may be duplicated when included into another micro-frontend #3263

Closed
JBWatenbergScality opened this issue Apr 6, 2021 · 0 comments
Closed

ui: shared styled components classnames may be duplicated when included into another micro-frontend #3263

JBWatenbergScality opened this issue Apr 6, 2021 · 0 comments
Labels
topic:ui UI-related issues

Comments

@JBWatenbergScality
Copy link
Contributor

Component:

ui

What happened:

ClassNames were duplicated when integrating shell-ui navbar within another micro frontend.

What was expected:

Generated class names should be unique per components/micro-frontend to avoid duplication and styling issues.

Resolution proposal:

As recommended by styled component documentation (https://styled-components.com/docs/tooling#namespace), class names should be name-spaced per micro-app to avoid collisions.
@JBWatenbergScality JBWatenbergScality added the topic:ui UI-related issues label Apr 6, 2021
JBWatenbergScality added a commit that referenced this issue Apr 6, 2021
@JBWatenbergScality
shell-ui: Add styled-component namespacing
2b4ba53 
Closes: #3263
@JBWatenbergScality JBWatenbergScality mentioned this issue Apr 6, 2021
Merged
JBWatenbergScality added a commit that referenced this issue Apr 6, 2021
@JBWatenbergScality
shell-ui: Add styled-component namespacing
a8f739d 
Closes: #3263
JBWatenbergScality added a commit that referenced this issue Apr 6, 2021
@JBWatenbergScality
shell-ui: Add styled-component namespacing
c86b66c 
Closes: #3263
JBWatenbergScality added a commit that referenced this issue Apr 6, 2021
@JBWatenbergScality
shell-ui: Add styled-component namespacing
1bc0944 
Closes: #3263
JBWatenbergScality added a commit that referenced this issue Apr 8, 2021
@JBWatenbergScality
shell-ui: Add styled-component namespacing
a1da909 
Closes: #3263
@bert-e bert-e closed this as completed in ebde300 Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic:ui UI-related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JBWatenbergScality