Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the Alertmanager notification configurations as a service configuration #2262

Closed
Ebaneck opened this issue Feb 26, 2020 · 0 comments
Closed
Assignees
Labels
topic:operations Operations-related issues

Comments

@Ebaneck
Copy link
Contributor

Ebaneck commented Feb 26, 2020

Component:

'salt', 'kubernetes', 'alertmanager'

Why this is needed:

For persistence of Alertmanager notification configurations, we need to store these service configurations using a ConfigMap.

Here, we are talking about integrations to Slack, email(smtp), victorops etc

What should be done:

  • Define the schema and default values for this ConfigMap
  • Deploy the ConfigMap holding these service values
  • Template and render the prometheus-operator charts to read cluster and service configurations from the ConfigMaps directly.

Implementation proposal (strongly recommended):

Test plan:

Epic #1996

@Ebaneck Ebaneck added topic:operations Operations-related issues topic: cluster&service configuration Anything related to cluster and service configuration persistence labels Feb 26, 2020
@Ebaneck Ebaneck removed the topic: cluster&service configuration Anything related to cluster and service configuration persistence label Feb 27, 2020
@Ebaneck Ebaneck self-assigned this Mar 5, 2020
Ebaneck added a commit that referenced this issue Mar 5, 2020
… template engine

Using the helm template engine with Alertmanager configurations
(Alertmanager.yaml) does not seem to work as expected.
It looks like the helm template engine does not recognise any
new config values since all configuration use cases are not
templated.

We resolve to creating a new secret which will be used to override
the default values making it possible for users to edit the
configuration settings.

Closes: #2262
Ebaneck added a commit that referenced this issue Mar 5, 2020
… template engine

Using the helm template engine with Alertmanager configurations
(Alertmanager.yaml) does not seem to work as expected.
It looks like the helm template engine does not recognise any
new config values since all configuration use cases are not
templated.

We resolve to creating a new secret which will be used to override
the default values making it possible for users to edit the
configuration settings.

Closes: #2262
Ebaneck added a commit that referenced this issue Mar 5, 2020
… template engine

Using the helm template engine with Alertmanager configurations
(Alertmanager.yaml) does not seem to work as expected.
It looks like the helm template engine does not recognise any
new config values since all configuration use cases are not
templated.

We resolve to creating a new secret which will be used to override
the default values making it possible for users to edit the
configuration settings.

Closes: #2262
Ebaneck added a commit that referenced this issue Mar 5, 2020
…emplate engine

Using the helm template engine with Alertmanager configurations
(Alertmanager.yaml) does not seem to work as expected.
It looks like the helm template engine does not recognise any
new config values since all configuration use cases are not
templated.

We resolve to creating a new secret which will be used to override
the default values making it possible for users to edit the
configuration settings.

Closes: #2262
Ebaneck added a commit that referenced this issue Mar 6, 2020
…emplate engine

Using the helm template engine with Alertmanager configurations
(Alertmanager.yaml) does not seem to work as expected because
the templated variables are directly base64 encoded instead
of being replaced during the yaml dump.

We resolve to creating a new secret which will be used to override
the default values making it possible for users to edit the
configuration settings.

Closes: #2262
@bert-e bert-e closed this as completed in 26238d2 Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:operations Operations-related issues
Projects
None yet
Development

No branches or pull requests

1 participant