Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade process is wrong #2101

Closed
TeddyAndrieux opened this issue Dec 6, 2019 · 0 comments
Closed

Downgrade process is wrong #2101

TeddyAndrieux opened this issue Dec 6, 2019 · 0 comments
Assignees
Labels
complexity:medium Something that requires one or few days to fix kind:bug Something isn't working state:question Further information is requested topic:lifecycle Issues related to upgrade or downgrade of MetalK8s

Comments

@TeddyAndrieux
Copy link
Collaborator

TeddyAndrieux commented Dec 6, 2019

Component:

'salt', 'downgrade'

What happened:

Current downgrade process:

- Downgrade workload plane nodes and then control plane nodes (except bootstrap one) <-- (including etcd ....)
- Downgrade etcd cluster <-- (automatically done when downgrading other nodes)
- Downgrade k8s objects
- Downgrade bootstrap stuff (salt-master, repositories, ...)

Several issues:

  • if we need ext_pillar informations when downgrading nodes or etcd that use some stuff only available with old salt-master we can't as we downgrade the salt-master at the end
  • downgrading of etcd it's done when downgrading node and downgrade of etcd basically do nothing

What was expected:

Being able to use old ext_pillar only available with old salt-master when downgrading

Resolution proposal (optional):

TBD:
Changes the downgrade process order:

- Apply bunch of pre-downgrade k8s states (cleanup no longer used objects, ...)
- Downgrade bootstrap stuff (salt-master, repositories, ...)
- Downgrade workload plane nodes and then control plane nodes (removing `etcd` role from pillar when calling highstate)
- Downgrade etcd cluster
- Downgrade kubernetes objects (NOTE: this one may be moved right after "downgrade of bootstrap stuff", TBD)
@TeddyAndrieux TeddyAndrieux added kind:bug Something isn't working state:question Further information is requested moonshot topic:lifecycle Issues related to upgrade or downgrade of MetalK8s complexity:medium Something that requires one or few days to fix labels Dec 6, 2019
@TeddyAndrieux TeddyAndrieux added this to the MetalK8s 2.4.2 milestone Dec 6, 2019
@TeddyAndrieux TeddyAndrieux self-assigned this Dec 9, 2019
TeddyAndrieux added a commit that referenced this issue Dec 9, 2019
Some ext_pillar need a salt-master already in the dest_version to be
computed, so we need to first downgrade salt-master before applying
highstate on other nodes

Fixes: #2101
bert-e added a commit that referenced this issue Dec 9, 2019
TeddyAndrieux added a commit that referenced this issue Dec 10, 2019
Some ext_pillar need a salt-master already in the dest_version to be
computed, so we need to first downgrade salt-master before applying
highstate on other nodes

Fixes: #2101
bert-e added a commit that referenced this issue Dec 10, 2019
TeddyAndrieux added a commit that referenced this issue Dec 10, 2019
Some ext_pillar need a salt-master already in the dest_version to be
computed, so we need to first downgrade salt-master before applying
highstate on other nodes

Fixes: #2101
bert-e added a commit that referenced this issue Dec 10, 2019
bert-e added a commit that referenced this issue Dec 10, 2019
bert-e added a commit that referenced this issue Dec 11, 2019
bert-e added a commit that referenced this issue Dec 11, 2019
bert-e added a commit that referenced this issue Dec 11, 2019
bert-e added a commit that referenced this issue Dec 11, 2019
bert-e added a commit that referenced this issue Dec 11, 2019
bert-e added a commit that referenced this issue Dec 11, 2019
bert-e added a commit that referenced this issue Dec 11, 2019
@bert-e bert-e closed this as completed in b8b528b Dec 11, 2019
TeddyAndrieux added a commit that referenced this issue Dec 12, 2019
This reverts commit c5ef29b.
Downgrade is fixed by #2101
TeddyAndrieux added a commit that referenced this issue Dec 12, 2019
This reverts commit c5ef29b.
Downgrade is fixed by #2101

Sees: #2058
ChengYanJin pushed a commit that referenced this issue Dec 17, 2019
This reverts commit c5ef29b.
Downgrade is fixed by #2101

Sees: #2058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:medium Something that requires one or few days to fix kind:bug Something isn't working state:question Further information is requested topic:lifecycle Issues related to upgrade or downgrade of MetalK8s
Projects
None yet
Development

No branches or pull requests

1 participant