Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle networking MTUs #1095

Closed
NicolasT opened this issue May 8, 2019 · 1 comment · Fixed by #2677
Closed

Handle networking MTUs #1095

NicolasT opened this issue May 8, 2019 · 1 comment · Fixed by #2677
Assignees
@TeddyAndrieux
Labels
topic:deployment Bugs in or enhancements to deployment stages topic:networking Networking-related issues

Comments

@NicolasT
Copy link
Contributor

NicolasT commented May 8, 2019

We currently hard-code the veth MTU to 1440 (the Calico self-hosted manifest default). However, this is a 'pessimistic' default, based on GCP deployment infrastructure.

Instead, since we don't enable IPIP by default, we should

  • Ensure the MTU as configured in the CNI configuration file is equal to the MTU of the workload-plane interface on the node, I believe, and
  • Set the MTU of the created IPIP tunnels to either a configurable value, or the MTU of the workload-plane interface minus the IPIP header size, i.e. 20 bytes

This would at least allow for 60bytes extra per packet on 'regular' ethernet networks, or 7560 bytes on networks configured with jumbo-frames.
@NicolasT NicolasT added topic:networking Networking-related issues topic:deployment Bugs in or enhancements to deployment stages moonshot labels May 8, 2019
@gdemonet
Copy link
Contributor

For reference: https://docs.projectcalico.org/networking/mtu

@gdemonet gdemonet mentioned this issue Jul 20, 2020
Open
@TeddyAndrieux TeddyAndrieux self-assigned this Jul 23, 2020
TeddyAndrieux added a commit that referenced this issue Jul 23, 2020
@TeddyAndrieux
salt: Add get_mtu_from_ip function in `metalk8s_network
7a9299c 
Add a function in `metalk8s_network` salt module to retrieve MTU
configured on an interface from an IP (will be needed to check MTU on
workload plane network before configuring calico #1095)
TeddyAndrieux added a commit that referenced this issue Jul 23, 2020
@TeddyAndrieux
salt: Make service network mtu configurable
6eebb11 
Add a `mtu` key in bootstrap configuration to configure the value for
MTU on service network, this value is used by calico to create the
interface for service network.
NOTE: We set the calico MTU to the configured MTU - 20 so that if IPinIP
is enabled the MTU is still valid

Fixes: #1095
TeddyAndrieux added a commit that referenced this issue Jul 23, 2020
@TeddyAndrieux
salt: Make service network mtu configurable
2575b13 
Add a `mtu` key in bootstrap configuration to configure the value for
MTU on service network, this value is used by calico to create the
interface for service network.
NOTE: We set the calico MTU to the configured MTU - 20 so that if IPinIP
is enabled the MTU is still valid

Fixes: #1095
TeddyAndrieux added a commit that referenced this issue Jul 23, 2020
@TeddyAndrieux
salt: Make service network mtu configurable
8e37b27 
Add a `mtu` key in bootstrap configuration to configure the value for
MTU on service network, this value is used by calico to create the
interface for service network.
NOTE: We set the calico MTU to the configured MTU - 20 so that if IPinIP
is enabled the MTU is still valid

Fixes: #1095
TeddyAndrieux added a commit that referenced this issue Jul 23, 2020
@TeddyAndrieux
salt: Add get_mtu_from_ip function in `metalk8s_network
887a321 
Add a function in `metalk8s_network` salt module to retrieve MTU
configured on an interface from an IP (will be needed to check MTU on
workload plane network before configuring calico #1095)
TeddyAndrieux added a commit that referenced this issue Jul 23, 2020
@TeddyAndrieux
salt: Make service network mtu configurable
bb3674e 
Add a `mtu` key in bootstrap configuration to configure the value for
MTU on service network, this value is used by calico to create the
interface for service network.
NOTE: We set the calico MTU to the configured MTU - 20 so that if IPinIP
is enabled the MTU is still valid

Fixes: #1095
@TeddyAndrieux TeddyAndrieux mentioned this issue Jul 23, 2020
Merged
6 tasks
TeddyAndrieux added a commit that referenced this issue Jul 28, 2020
@TeddyAndrieux
salt: Add get_mtu_from_ip function in `metalk8s_network
c5a69ba 
Add a function in `metalk8s_network` salt module to retrieve MTU
configured on an interface from an IP (will be needed to check MTU on
workload plane network before configuring calico #1095)
TeddyAndrieux added a commit that referenced this issue Jul 28, 2020
@TeddyAndrieux
salt: Make Pod network mtu configurable
de68d1d 
Add a `mtu` key in bootstrap configuration to configure the value for
MTU on Pod network, this value is used by calico to create the
interface for Pod network.
NOTE: We set the calico MTU to the workload MTU - 20 so that if IPinIP
is enabled the MTU is still valid

Fixes: #1095
TeddyAndrieux added a commit that referenced this issue Jul 28, 2020
@TeddyAndrieux
salt: Make Pod network mtu configurable
1c24612 
Add a `mtu` key in bootstrap configuration to configure the value for
MTU on Pod network, this value is used by calico to create the
interface for Pod network.
NOTE: We set the calico MTU to the workload MTU - 20 so that if IPinIP
is enabled the MTU is still valid

Fixes: #1095
TeddyAndrieux added a commit that referenced this issue Jul 28, 2020
@TeddyAndrieux
salt: Make Pod network mtu configurable
084e6cc 
Add a `mtu` key in bootstrap configuration to configure the value for
MTU on Pod network, this value is used by calico to create the
interface for Pod network.
NOTE: We set the calico MTU to the workload MTU - 20 so that if IPinIP
is enabled the MTU is still valid

Fixes: #1095
TeddyAndrieux added a commit that referenced this issue Jul 28, 2020
@TeddyAndrieux
salt: Make Pod network mtu configurable
76534b1 
Add a `mtu` key in bootstrap configuration to configure the value for
MTU on Pod network, this value is used by calico to create the
interface for Pod network.
NOTE: We set the calico MTU to the workload MTU - 20 so that if IPinIP
is enabled the MTU is still valid

Fixes: #1095
TeddyAndrieux added a commit that referenced this issue Jul 28, 2020
@TeddyAndrieux
salt: Make Pod network mtu configurable
18f9baa 
Add a `mtu` key in bootstrap configuration to configure the value for
MTU on Pod network, this value is used by calico to create the
interface for Pod network.
NOTE: We set the calico MTU to the workload MTU - 20 so that if IPinIP
is enabled the MTU is still valid

Fixes: #1095
TeddyAndrieux added a commit that referenced this issue Jul 28, 2020
@TeddyAndrieux
salt: Make Pod network mtu configurable
8fbd839 
Add a `mtu` key in bootstrap configuration to configure the value for
MTU on Pod network, this value is used by calico to create the
interface for Pod network.
NOTE: We set the calico MTU to the workload MTU - 20 so that if IPinIP
is enabled the MTU is still valid

Fixes: #1095
TeddyAndrieux added a commit that referenced this issue Jul 28, 2020
@TeddyAndrieux
salt: Make Pod network mtu configurable
2f26202 
Add a `mtu` key in bootstrap configuration to configure the value for
MTU on Pod network, this value is used by calico to create the
interface for Pod network.
NOTE: We set the calico MTU to the workload MTU - 20 so that if IPinIP
is enabled the MTU is still valid

Fixes: #1095
TeddyAndrieux added a commit that referenced this issue Jul 29, 2020
@TeddyAndrieux
salt: Add get_mtu_from_ip function in `metalk8s_network
e07551d 
Add a function in `metalk8s_network` salt module to retrieve MTU
configured on an interface from an IP (will be needed to check MTU on
workload plane network before configuring calico #1095)
TeddyAndrieux added a commit that referenced this issue Jul 29, 2020
@TeddyAndrieux
salt: Make Pod network mtu configurable
b262873 
Add a `mtu` key in bootstrap configuration to configure the value for
MTU on Pod network, this value is used by calico to create the
interface for Pod network.
NOTE: We set the calico MTU to the workload MTU - 20 so that if IPinIP
is enabled the MTU is still valid

Fixes: #1095
TeddyAndrieux added a commit that referenced this issue Jul 29, 2020
@TeddyAndrieux
salt: Add get_mtu_from_ip function in `metalk8s_network
77f3ef9 
Add a function in `metalk8s_network` salt module to retrieve MTU
configured on an interface from an IP (will be needed to check MTU on
workload plane network before configuring calico #1095)
TeddyAndrieux added a commit that referenced this issue Jul 29, 2020
@TeddyAndrieux
salt: Make Pod network mtu configurable
c228607 
Add a `mtu` key in bootstrap configuration to configure the value for
MTU on Pod network, this value is used by calico to create the
interface for Pod network.
NOTE: We set the calico MTU to the workload MTU - 20 so that if IPinIP
is enabled the MTU is still valid

Fixes: #1095
TeddyAndrieux added a commit that referenced this issue Jul 29, 2020
@TeddyAndrieux
salt: Add get_mtu_from_ip function in `metalk8s_network
a77413e 
Add a function in `metalk8s_network` salt module to retrieve MTU
configured on an interface from an IP (will be needed to check MTU on
workload plane network before configuring calico #1095)
TeddyAndrieux added a commit that referenced this issue Jul 29, 2020
@TeddyAndrieux
salt: Make Pod network mtu configurable
5457525 
Add a `mtu` key in bootstrap configuration to configure the value for
MTU on Pod network, this value is used by calico to create the
interface for Pod network.
NOTE: We set the calico MTU to the workload MTU - 20 so that if IPinIP
is enabled the MTU is still valid

Fixes: #1095
TeddyAndrieux added a commit that referenced this issue Jul 30, 2020
@TeddyAndrieux
salt: Add get_mtu_from_ip function in `metalk8s_network
28c4010 
Add a function in `metalk8s_network` salt module to retrieve MTU
configured on an interface from an IP (will be needed to check MTU on
workload plane network before configuring calico #1095)
TeddyAndrieux added a commit that referenced this issue Jul 30, 2020
@TeddyAndrieux
salt: Make Pod network mtu configurable
ff0b6de 
Add a `mtu` key in bootstrap configuration to configure the value for
MTU on Pod network, this value is used by calico to create the
interface for Pod network.
NOTE: We set the calico MTU to the workload MTU - 20 so that if IPinIP
is enabled the MTU is still valid

Fixes: #1095
TeddyAndrieux added a commit that referenced this issue Jul 30, 2020
@TeddyAndrieux
salt: Add get_mtu_from_ip function in `metalk8s_network
248ced7 
Add a function in `metalk8s_network` salt module to retrieve MTU
configured on an interface from an IP (will be needed to check MTU on
workload plane network before configuring calico #1095)
TeddyAndrieux added a commit that referenced this issue Jul 30, 2020
@TeddyAndrieux
salt: Make Pod network mtu configurable
8e7d2ac 
Add a `mtu` key in bootstrap configuration to configure the value for
MTU on Pod network, this value is used by calico to create the
interface for Pod network.
NOTE: We set the calico MTU to the workload MTU - 20 so that if IPinIP
is enabled the MTU is still valid

Fixes: #1095
TeddyAndrieux added a commit that referenced this issue Jul 30, 2020
@TeddyAndrieux
docs: Add documentation about workloadPlane MTU configuration
6b0e6b7 
Add a small paragraph about MTU value that may be provided for
workloadPlane network in BootstrapConfiguration

Refs: #1095
TeddyAndrieux added a commit that referenced this issue Jul 30, 2020
@TeddyAndrieux
changelog: Add entry about multiple CIDRs support configurable MTU
15b657c 
Add a changelog entry about the ability to use multiple CIDRs for
workload and control plane networks and to configure the MTU used by
Calico

Refs: #1095
TeddyAndrieux added a commit that referenced this issue Jul 31, 2020
@TeddyAndrieux
changelog: Add entry about multiple CIDRs support configurable MTU
60877dc 
Add a changelog entry about the ability to use multiple CIDRs for
workload and control plane networks and to configure the MTU used by
Calico

Refs: #1095
This was referenced Jul 31, 2020
Open
Closed
TeddyAndrieux added a commit that referenced this issue Jul 31, 2020
@TeddyAndrieux
salt: Make Pod network mtu configurable
3be7abc 
Add a `mtu` key in bootstrap configuration to configure the value for
MTU on Pod network, this value is used by calico to create the
interface for Pod network.
NOTE: We set the calico MTU to the workload MTU - 20 so that if IPinIP
is enabled the MTU is still valid

Fixes: #1095
TeddyAndrieux added a commit that referenced this issue Jul 31, 2020
@TeddyAndrieux
docs: Add documentation about workloadPlane MTU configuration
59d9102 
Add a small paragraph about MTU value that may be provided for
workloadPlane network in BootstrapConfiguration

Refs: #1095
TeddyAndrieux added a commit that referenced this issue Jul 31, 2020
@TeddyAndrieux
changelog: Add entry about multiple CIDRs support configurable MTU
2275742 
Add a changelog entry about the ability to use multiple CIDRs for
workload and control plane networks and to configure the MTU used by
Calico

Refs: #1095
TeddyAndrieux added a commit that referenced this issue Jul 31, 2020
@TeddyAndrieux
salt: Add get_mtu_from_ip function in `metalk8s_network
ca8397f 
Add a function in `metalk8s_network` salt module to retrieve MTU
configured on an interface from an IP (will be needed to check MTU on
workload plane network before configuring calico #1095)
TeddyAndrieux added a commit that referenced this issue Jul 31, 2020
@TeddyAndrieux
docs: Add documentation about workloadPlane MTU configuration
d964cc5 
Add a small paragraph about MTU value that may be provided for
workloadPlane network in BootstrapConfiguration

Refs: #1095
TeddyAndrieux added a commit that referenced this issue Jul 31, 2020
@TeddyAndrieux
changelog: Add entry about multiple CIDRs support configurable MTU
25193fe 
Add a changelog entry about the ability to use multiple CIDRs for
workload and control plane networks and to configure the MTU used by
Calico

Refs: #1095
@bert-e bert-e closed this as completed in d187309 Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TeddyAndrieux TeddyAndrieux

Labels
topic:deployment Bugs in or enhancements to deployment stages topic:networking Networking-related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make calico MTU configurable in bootstrap config scality/metalk8s
3 participants
@NicolasT @TeddyAndrieux @gdemonet