Skip to content

Commit

Permalink
build,packages: Restrict runc version
Browse files Browse the repository at this point in the history
The runc version 1.1.3, recently added in upstream repositories for
RHEL/Rocky 8, seems to include a bug causing issues with "exec" in
containers.
We explicitly reject this version in the RPM `Requires` line, hoping
that future versions will have this issue fixed.

See: containerd/containerd#7219
  • Loading branch information
gdemonet committed Aug 5, 2022
1 parent 17a6ad7 commit 733f86a
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
2 changes: 1 addition & 1 deletion buildchain/buildchain/versions.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
CONTAINERD_VERSION: str = "1.6.4"

CALICO_RELEASE: str = "1"
CONTAINERD_RELEASE: str = "1"
CONTAINERD_RELEASE: str = "2"
SOSREPORT_RELEASE: str = "2"


Expand Down
13 changes: 11 additions & 2 deletions packages/redhat/common/containerd.spec
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ go build -compiler gc -tags="rpm_crashtraceback ${BUILDTAGS:-seccomp %{!?el7:no_


Name: containerd
Release: 1%{?dist}
Release: 2%{?dist}
Summary: An industry-standard container runtime
License: ASL 2.0
URL: https://containerd.io
Expand All @@ -54,7 +54,13 @@ BuildRequires: go-md2man
BuildRequires: libseccomp-devel
BuildRequires: systemd
%{?systemd_requires}
Requires: runc
# NOTE: A bug in runc 1.1.3 seems to cause issues with "exec" in containers
# See https://github.com/containerd/containerd/issues/7219
%if 0%{?el7}
Requires: runc < 1.1.3
%else
Requires: (runc < 1.1.3 or runc > 1.1.3)
%endif

# vendored libraries
# From github.com/containerd/containerd repository, checkout the corresponding version and run:
Expand Down Expand Up @@ -549,6 +555,9 @@ install -D -p -m 0644 %{S:3} %{buildroot}%{_sysctldir}/60-containerd.conf


%changelog
* Fri Aug 5 2022 Guillaume Demonet <[email protected]> - 1.6.4-2
- Constrain runc version to avoid issue with "exec"

* Wed May 25 2022 Guillaume Demonet <[email protected]> - 1.6.4-1
- Latest upstream

Expand Down

0 comments on commit 733f86a

Please sign in to comment.