Skip to content

Commit

Permalink
ui/styles: Fix the scroll bar issue by overflow:auto
Browse files Browse the repository at this point in the history
"overflow-y: scroll" protentially would display the scrollbar by default
even for non scrollable content, which casue the issue of we have the
scrollbar everywhere.

Refs: #2964
  • Loading branch information
ChengYanJin committed Dec 17, 2020
1 parent 296aca3 commit 1410b8a
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion ui/src/components/CommonLayoutStyle.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const RightSidePanel = styled.div`
flex-direction: column;
width: 51%;
/* Make it scrollable for the small laptop screen */
overflow-y: scroll;
overflow-y: auto;
margin: 0 ${padding.small} 0 8px;
`;

Expand Down
4 changes: 2 additions & 2 deletions ui/src/components/NodeListTable.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const NodeListContainer = styled.div`
width: 100%;
}
.ReactTable .rt-thead {
overflow-y: scroll;
overflow-y: auto;
}
table {
border-spacing: 0;
Expand Down Expand Up @@ -112,7 +112,7 @@ const Body = styled.tbody`
display: block;
height: calc(100vh - 250px);
overflow: auto;
overflow-y: scroll;
overflow-y: auto;
`;

const Cell = styled.td`
Expand Down
2 changes: 1 addition & 1 deletion ui/src/components/NodePageAlertsTab.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const Body = styled.tbody`
display: block;
height: calc(100vh - 250px);
overflow: auto;
overflow-y: scroll;
overflow-y: auto;
`;

const ActiveAlertsText = styled.div`
Expand Down
4 changes: 2 additions & 2 deletions ui/src/components/NodePagePodsTab.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const PodTableContainer = styled.div`
font-size: ${fontSize.base};
border-color: ${(props) => props.theme.brand.borderLight};
.ReactTable .rt-thead {
overflow-y: scroll;
overflow-y: auto;
}
table {
border-spacing: 0;
Expand Down Expand Up @@ -49,7 +49,7 @@ const Body = styled.tbody`
display: block;
height: calc(100vh - 250px);
overflow: auto;
overflow-y: scroll;
overflow-y: auto;
`;

const Cell = styled.td`
Expand Down
2 changes: 1 addition & 1 deletion ui/src/components/VolumeAlertsTab.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ const Body = styled.tbody`
display: block;
height: calc(100vh - 250px);
overflow: auto;
overflow-y: scroll;
overflow-y: auto;
`;

const ActiveAlertsCard = (props) => {
Expand Down
4 changes: 2 additions & 2 deletions ui/src/components/VolumeListTable.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const VolumeListContainer = styled.div`
background-color: ${(props) => props.theme.brand.secondaryDark1};
}
.ReactTable .rt-thead {
overflow-y: scroll;
overflow-y: auto;
}
table {
border-spacing: 0;
Expand Down Expand Up @@ -126,7 +126,7 @@ const Body = styled.tbody`
display: block;
height: calc(100vh - 250px);
overflow: auto;
overflow-y: scroll;
overflow-y: auto;
`;

const Cell = styled.td`
Expand Down
2 changes: 1 addition & 1 deletion ui/src/containers/CreateVolume.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const ActionContainer = styled.div`
const CreateVolumeLayout = styled.div`
display: inline-block;
margin-top: ${padding.base};
overflow-y: scroll;
overflow-y: auto;
height: 85vh;
form {
.sc-input {
Expand Down

0 comments on commit 1410b8a

Please sign in to comment.