salt: Do not longer remove Loki service instance post-upgrade

Fix a bug that delete the Loki service instance post-upgrade when it
shouldn't.

This Loki service instance and grafana datasources are deployed to
mitigate a Loki limitation when working with multi instances

See: abc293a

CHANGELOG.md

@@ -6,6 +6,10 @@
   ignore the Ingress object that does not have the class explicitly set
   (PR[#3704](https://github.com/scality/metalk8s/pull/3704))
 
+- Fix a bug during the upgrade that remove the Loki instance services used by
+  Grafana datasources
+  (PR[#3717](https://github.com/scality/metalk8s/pull/3717))
+
 ## Release 2.11.2
 ### Bug fixes
 

buildchain/buildchain/salt_tree.py

@@ -336,7 +336,6 @@ def task(self) -> types.TaskDict:
     Path("salt/metalk8s/addons/logging/loki/deployed/loki-configuration-secret.sls"),
     Path("salt/metalk8s/addons/logging/loki/deployed/service.sls"),
     Path("salt/metalk8s/addons/logging/loki/deployed/service-configuration.sls"),
-    Path("salt/metalk8s/addons/logging/loki/post-upgrade.sls"),
     Path("salt/metalk8s/addons/prometheus-adapter/deployed/chart.sls"),
     Path("salt/metalk8s/addons/prometheus-adapter/deployed/init.sls"),
     Path("salt/metalk8s/addons/prometheus-operator/macros.j2"),

salt/metalk8s/orchestrate/upgrade/post.sls

@@ -2,5 +2,4 @@
 
 include:
   - metalk8s.addons.prometheus-operator.post-upgrade
-  - metalk8s.addons.logging.loki.post-upgrade
   - metalk8s.addons.ui.post-upgrade