Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input: Number type input #213

Merged
merged 9 commits into from
Jan 8, 2021
Merged

Input: Number type input #213

merged 9 commits into from
Jan 8, 2021

Conversation

alexis-ld
Copy link
Contributor

Component:
Input

Description:

This adds a number type input as specified in #211 .

Design:

I kept the existing Input design for consistency and made it work with type="number" cases.

Screenshot 2020-12-15 at 15 56 14


Closes: #211

@bert-e
Copy link
Contributor

bert-e commented Dec 15, 2020

Hello alexis-ld,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 15, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

Copy link
Contributor

@ChengYanJin ChengYanJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes required.

Most importantly, please test the arrows to see if increment and decrement work.

stories/input.js Outdated Show resolved Hide resolved
src/lib/components/input/Input.component.js Outdated Show resolved Hide resolved
src/lib/components/input/Input.component.js Outdated Show resolved Hide resolved
src/lib/components/input/Input.component.style.js Outdated Show resolved Hide resolved
src/lib/components/input/Input.component.style.js Outdated Show resolved Hide resolved
stories/input.js Outdated Show resolved Hide resolved
@bert-e
Copy link
Contributor

bert-e commented Dec 16, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@bert-e
Copy link
Contributor

bert-e commented Dec 20, 2020

Conflict

There is a conflict between your branch feature/number-input and the
destination branch development/1.0.

Please resolve the conflict on the feature branch (feature/number-input).

 $ git fetch
 $ git checkout origin/feature/number-input
 $ git merge origin/development/1.0
 $ # <intense conflict resolution>
 $ git commit
 $ git push origin HEAD:feature/number-input

@bert-e
Copy link
Contributor

bert-e commented Dec 20, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@ChengYanJin ChengYanJin self-assigned this Dec 21, 2020
@alexis-ld alexis-ld force-pushed the feature/number-input branch from 31c50ee to 483a8ea Compare December 21, 2020 17:19
@alexis-ld
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Dec 21, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

The following options are set: approve

Copy link
Contributor

@ChengYanJin ChengYanJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an error state number input in the storybook, and fix the bug of the carets are outside the input component.

Thanks

Moved relative positioning to number input wrapper instead of global input wrapper. The initial positionning was causing caret displacement when an error was specified.

Refs: #211
@ChengYanJin ChengYanJin force-pushed the feature/number-input branch 4 times, most recently from 9562f6b to 648c900 Compare January 8, 2021 11:41
@alexis-ld alexis-ld force-pushed the feature/number-input branch from 648c900 to 3cac554 Compare January 8, 2021 14:01
Copy link
Contributor

@ChengYanJin ChengYanJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Great solution align-items: baseline;!

@bert-e
Copy link
Contributor

bert-e commented Jan 8, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 8, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.0

Please check the status of the associated issue None.

Goodbye alexis-ld.

@bert-e bert-e merged commit 1f005d7 into development/1.0 Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number selection Input
3 participants