-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input: Number type input #213
Conversation
Hello alexis-ld,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes required.
Most importantly, please test the arrows to see if increment and decrement work.
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: The following reviewers are expecting changes from the author, or must review again: |
2e0f6e1
to
ca97d7b
Compare
ConflictThere is a conflict between your branch Please resolve the conflict on the feature branch ( $ git fetch
$ git checkout origin/feature/number-input
$ git merge origin/development/1.0
$ # <intense conflict resolution>
$ git commit
$ git push origin HEAD:feature/number-input |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: The following reviewers are expecting changes from the author, or must review again: |
31c50ee
to
483a8ea
Compare
/approve |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: The following reviewers are expecting changes from the author, or must review again: The following options are set: approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an error state number input in the storybook, and fix the bug of the carets are outside the input component.
Thanks
Moved relative positioning to number input wrapper instead of global input wrapper. The initial positionning was causing caret displacement when an error was specified. Refs: #211
9562f6b
to
648c900
Compare
648c900
to
3cac554
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Great solution align-items: baseline;
!
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
Please check the status of the associated issue None. Goodbye alexis-ld. |
Component:
Input
Description:
This adds a number type input as specified in #211 .
Design:
I kept the existing Input design for consistency and made it work with type="number" cases.
Closes: #211