Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to NodeJS 22 #5734

Merged
merged 22 commits into from
Feb 18, 2025
Merged

Conversation

williamlardier
Copy link
Contributor

@williamlardier williamlardier commented Feb 13, 2025

Several bumps and edits to make cloudserver compatible with node 22.

From #5711

Two next tickets to work on after this PR:

  • ARSN-449 to move a function unit-tested here while it should be in arsenal.
  • CLDSRV-596 to re-enable utapi-related code (also causing temporarily a drop in the codecov score).

New PR because all commits were reworked.

@bert-e
Copy link
Contributor

bert-e commented Feb 13, 2025

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 13, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@williamlardier williamlardier force-pushed the improvement/CLDSRV-553-bump-deps-3 branch from 8a2f2c8 to 6a56c76 Compare February 13, 2025 16:35
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 51.72414% with 14 lines in your changes missing coverage. Please review.

Project coverage is 64.64%. Comparing base (de8fec1) to head (e005390).
Report is 22 commits behind head on development/9.0.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/utapi/utapiReindex.js 0.00% 6 Missing ⚠️
lib/utapi/utapiReplay.js 0.00% 4 Missing ⚠️
lib/utapi/utilities.js 25.00% 3 Missing ⚠️
lib/utapi/utapi.js 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (51.72%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
bin/create_bucket_with_NFS_enabled.js 0.00% <ø> (ø)
bin/create_encrypted_bucket.js 0.00% <ø> (ø)
bin/list_bucket_metrics.js 0.00% <ø> (ø)
bin/list_metrics.js 0.00% <ø> (ø)
bin/metrics_server.js 0.00% <ø> (ø)
bin/search_bucket.js 0.00% <ø> (ø)
bin/secure_channel_proxy.js 0.00% <ø> (ø)
lib/Config.js 75.09% <100.00%> (-2.57%) ⬇️
lib/api/api.js 80.85% <ø> (-1.07%) ⬇️
lib/api/apiUtils/authorization/permissionChecks.js 87.59% <ø> (ø)
... and 26 more

... and 2 files with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.0    #5734      +/-   ##
===================================================
- Coverage            64.92%   64.64%   -0.29%     
===================================================
  Files                  185      185              
  Lines                11668    11666       -2     
===================================================
- Hits                  7576     7541      -35     
- Misses                4092     4125      +33     
Flag Coverage Δ
unit 64.64% <51.72%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@williamlardier williamlardier force-pushed the improvement/CLDSRV-553-bump-deps-3 branch 2 times, most recently from fcb6e45 to 7b1565b Compare February 13, 2025 16:45
@williamlardier williamlardier force-pushed the improvement/CLDSRV-553-bump-deps-3 branch from 0c653a4 to e005390 Compare February 17, 2025 10:34
@williamlardier
Copy link
Contributor Author

williamlardier commented Feb 17, 2025

Note for reviewers: codecov is failing, but only due to deactivation of utapi. This is temporary and will be re-enabled in CLDSRV-610.

@williamlardier
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Feb 18, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.0

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

Please check the status of the associated issue CLDSRV-553.

Goodbye williamlardier.

The following options are set: approve

@bert-e bert-e merged commit e005390 into development/9.0 Feb 18, 2025
18 of 19 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-553-bump-deps-3 branch February 18, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants